Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-06 Thread Noralf Trønnes
(Adding Maxime) Den 06.02.2017 13.34, skrev Andrzej Hajda: On 06.02.2017 12:53, Thierry Reding wrote: On Mon, Feb 06, 2017 at 01:30:09PM +0200, Jani Nikula wrote: On Mon, 06 Feb 2017, Thierry Reding wrote: On Tue, Jan 31, 2017 at 05:03:15PM +0100, Noralf Trønnes wrote: Add support for MIPI

Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-06 Thread Andrzej Hajda
On 06.02.2017 12:53, Thierry Reding wrote: > On Mon, Feb 06, 2017 at 01:30:09PM +0200, Jani Nikula wrote: >> On Mon, 06 Feb 2017, Thierry Reding wrote: >>> On Tue, Jan 31, 2017 at 05:03:15PM +0100, Noralf Trønnes wrote: Add support for MIPI DBI compatible controllers. Interface type C op

Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-06 Thread Thierry Reding
On Mon, Feb 06, 2017 at 01:30:09PM +0200, Jani Nikula wrote: > On Mon, 06 Feb 2017, Thierry Reding wrote: > > On Tue, Jan 31, 2017 at 05:03:15PM +0100, Noralf Trønnes wrote: > >> Add support for MIPI DBI compatible controllers. > >> Interface type C option 1 and 3 are supported (SPI). > >> > >> S

Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-06 Thread Jani Nikula
On Mon, 06 Feb 2017, Thierry Reding wrote: > On Tue, Jan 31, 2017 at 05:03:15PM +0100, Noralf Trønnes wrote: >> Add support for MIPI DBI compatible controllers. >> Interface type C option 1 and 3 are supported (SPI). >> >> Signed-off-by: Noralf Trønnes >> --- >> Documentation/gpu/tinydrm.rst

Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-06 Thread Jani Nikula
On Tue, 31 Jan 2017, Noralf Trønnes wrote: > +static bool mipi_dbi_command_is_read(struct mipi_dbi *mipi, u8 cmd) Okay this is one giant bikeshedding nitpick, but here goes anyway. Why do you call MIPI DBI just "mipi", here and all around? Why not "mipi_dbi" or "dbi"? We never talk about "vesa" d

Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-06 Thread Thierry Reding
On Tue, Jan 31, 2017 at 05:03:15PM +0100, Noralf Trønnes wrote: > Add support for MIPI DBI compatible controllers. > Interface type C option 1 and 3 are supported (SPI). > > Signed-off-by: Noralf Trønnes > --- > Documentation/gpu/tinydrm.rst | 12 + > drivers/gpu/drm/tinydrm/Kconfig|

[PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-01-31 Thread Noralf Trønnes
Add support for MIPI DBI compatible controllers. Interface type C option 1 and 3 are supported (SPI). Signed-off-by: Noralf Trønnes --- Documentation/gpu/tinydrm.rst | 12 + drivers/gpu/drm/tinydrm/Kconfig|3 + drivers/gpu/drm/tinydrm/Makefile |3 + drivers/gpu/drm/tinydrm/m