[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-20 Thread Thierry Reding
On Mon, Apr 18, 2016 at 01:23:54PM +0200, Enric Balletbo i Serra wrote: > On 14/04/16 15:10, Thierry Reding wrote: > > On Fri, Apr 08, 2016 at 02:52:52PM +0200, Enric Balletbo i Serra wrote: [...] > > > + /* Map slave addresses of ANX7814 */ > > > + for (i = 0; i < I2C_NUM_ADDRESSES; i++) { > > > +

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-18 Thread Enric Balletbo i Serra
Hi, Many thanks for dedicate some time to comment the patch, I'm going to send a v4 version, see my comments below. On 14/04/16 15:10, Thierry Reding wrote: > On Fri, Apr 08, 2016 at 02:52:52PM +0200, Enric Balletbo i Serra wrote: >> Although there are other chips from the same family that can r

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-14 Thread Thierry Reding
On Thu, Apr 14, 2016 at 04:08:43PM +0200, Enric Balletbo i Serra wrote: > Hi Emil, > > On 14/04/16 16:06, Emil Velikov wrote: > > Hi Enric, > > > > On 14 April 2016 at 14:42, Enric Balletbo i Serra > > wrote: > > > The patch was implemented first without OR'ing error codes. The reason > > > why

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-14 Thread Enric Balletbo i Serra
Hi Emil, On 14/04/16 16:06, Emil Velikov wrote: > Hi Enric, > > On 14 April 2016 at 14:42, Enric Balletbo i Serra > wrote: >> The patch was implemented first without OR'ing error codes. The reason why I >> changed this is because I received the comments that checking the error on >> every regmap_

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-14 Thread Enric Balletbo i Serra
Hi Thierry, Many thanks for answering and do this accurate report. I'd add a comment on something you (see below). Apart from this I'll add your changes and send a new version. On 14/04/16 15:10, Thierry Reding wrote: > On Fri, Apr 08, 2016 at 02:52:52PM +0200, Enric Balletbo i Serra wrote: >>

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-14 Thread Thierry Reding
On Fri, Apr 08, 2016 at 02:52:52PM +0200, Enric Balletbo i Serra wrote: > Although there are other chips from the same family that can reuse this > driver, at the moment we only tested ANX7814 chip. > > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portabl

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-14 Thread Emil Velikov
Hi Enric, On 14 April 2016 at 14:42, Enric Balletbo i Serra wrote: > The patch was implemented first without OR'ing error codes. The reason why I > changed this is because I received the comments that checking the error on > every regmap_* didn't help the readability of the driver and is likely t

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-08 Thread Enric Balletbo i Serra
Although there are other chips from the same family that can reuse this driver, at the moment we only tested ANX7814 chip. The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. This driver adds initial support for HDMI to DP pass-through mode. Sig