[PATCH v3 21/22] drm/tilcdc: Initialize crtc->port

2016-02-23 Thread Jyri Sarha
On 02/23/16 17:32, Tomi Valkeinen wrote: > On 23/02/16 17:26, Jyri Sarha wrote: > >>> You didn't comment on why this is not an error? Why should the driver >>> continue even if crtc->port is missing? >>> >> >> At least for the time being if the drm_of_find_possible_crtcs() fails >> the tda998x driv

[PATCH v3 21/22] drm/tilcdc: Initialize crtc->port

2016-02-23 Thread Tomi Valkeinen
On 23/02/16 17:26, Jyri Sarha wrote: >> You didn't comment on why this is not an error? Why should the driver >> continue even if crtc->port is missing? >> > > At least for the time being if the drm_of_find_possible_crtcs() fails > the tda998x driver assumes the first crtc with a warning. So for

[PATCH v3 21/22] drm/tilcdc: Initialize crtc->port

2016-02-23 Thread Jyri Sarha
On 02/23/16 17:19, Tomi Valkeinen wrote: > > > On 23/02/16 17:03, Jyri Sarha wrote: >> Initialize port device node pointer in the tilcdc crtc. Fixes "Falling >> back to first CRTC" warning from tda998x driver. >> >> The tda998x encoder driver calls drm_of_find_possible_crtcs() to >> initialize poss

[PATCH v3 21/22] drm/tilcdc: Initialize crtc->port

2016-02-23 Thread Tomi Valkeinen
On 23/02/16 17:03, Jyri Sarha wrote: > Initialize port device node pointer in the tilcdc crtc. Fixes "Falling > back to first CRTC" warning from tda998x driver. > > The tda998x encoder driver calls drm_of_find_possible_crtcs() to > initialize possible_crtcs of struct drm_encoder. The crtc->port

[PATCH v3 21/22] drm/tilcdc: Initialize crtc->port

2016-02-23 Thread Jyri Sarha
Initialize port device node pointer in the tilcdc crtc. Fixes "Falling back to first CRTC" warning from tda998x driver. The tda998x encoder driver calls drm_of_find_possible_crtcs() to initialize possible_crtcs of struct drm_encoder. The crtc->port needs to be initialized for drm_of_find_possible_