Re: [PATCH v3 2/4] drm/vc4: Report underrun errors

2019-01-25 Thread Eric Anholt
Paul Kocialkowski writes: > Hi Eric, > > On Wed, 2019-01-23 at 10:47 -0800, Eric Anholt wrote: >> Paul Kocialkowski writes: >> > +void vc4_hvs_mask_underrun(struct drm_device *dev) >> > +{ >> > + struct vc4_dev *vc4 = to_vc4_dev(dev); >> > + u32 dispctrl = HVS_READ(SCALER_DISPCTRL); >> > + >>

Re: [PATCH v3 2/4] drm/vc4: Report underrun errors

2019-01-25 Thread Paul Kocialkowski
Hi Eric, On Wed, 2019-01-23 at 10:47 -0800, Eric Anholt wrote: > Paul Kocialkowski writes: > > > From: Boris Brezillon > > > > The DRM framework provides a generic way to report underrun errors. > > Let's implement the necessary hooks to support it in the VC4 driver. > > > > Signed-off-by: Bo

Re: [PATCH v3 2/4] drm/vc4: Report underrun errors

2019-01-23 Thread Eric Anholt
Paul Kocialkowski writes: > From: Boris Brezillon > > The DRM framework provides a generic way to report underrun errors. > Let's implement the necessary hooks to support it in the VC4 driver. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > - Generic underrun report function has bee

[PATCH v3 2/4] drm/vc4: Report underrun errors

2019-01-08 Thread Paul Kocialkowski
From: Boris Brezillon The DRM framework provides a generic way to report underrun errors. Let's implement the necessary hooks to support it in the VC4 driver. Signed-off-by: Boris Brezillon --- Changes in v3: - Generic underrun report function has been dropped, adjust the code accordingly Ch