Re: [PATCH v3 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-16 Thread Dan Murphy
Brian On 4/15/19 2:29 AM, Brian Masney wrote: > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney > --- > Rob: Since the common bindings aren't converted to the new JSON schema > yet, I'm not sure how to do led-sources here. I would expect that w

Re: [PATCH v3 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-16 Thread Brian Masney
On Mon, Apr 15, 2019 at 07:10:04AM -0500, Dan Murphy wrote: > I noticed we are missing "label". It is defined as optional and it is hard > coded in the driver > but wondering if there is a need to add it. OK, I'll make it optional and have it fall back to the hardcoded values if it is missing.

[PATCH v3 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-16 Thread Brian Masney
Add new backlight bindings for the TI LM3630A dual-string white LED. Signed-off-by: Brian Masney --- Rob: Since the common bindings aren't converted to the new JSON schema yet, I'm not sure how to do led-sources here. I would expect that we'd have the uint32-array on the common binding once it ex