Re: [PATCH v3 2/2] drm/panfrost: Use drm_gem_shmem_map_offset()

2019-06-10 Thread Rob Herring
On Wed, May 22, 2019 at 6:39 AM Steven Price wrote: > > On 21/05/2019 19:23, Chris Wilson wrote: > > Quoting Rob Herring (2019-05-21 16:24:27) > >> On Mon, May 20, 2019 at 4:23 AM Steven Price wrote: > >>> > >> > >> You forgot to update the subject. I can fixup when applying, but I'd > >> like an

[PATCH v3 2/2] drm/panfrost: Use drm_gem_shmem_map_offset()

2019-05-22 Thread Steven Price
panfrost_ioctl_mmap_bo() contains a reimplementation of drm_gem_map_offset() but with a bug - it allows mapping imported objects (without going through the exporter). Fix this by switching to use the newly renamed drm_gem_map_offset() function instead which has the bonus of simplifying the code. C

Re: [PATCH v3 2/2] drm/panfrost: Use drm_gem_shmem_map_offset()

2019-05-22 Thread Steven Price
On 21/05/2019 19:23, Chris Wilson wrote: > Quoting Rob Herring (2019-05-21 16:24:27) >> On Mon, May 20, 2019 at 4:23 AM Steven Price wrote: >>> >> >> You forgot to update the subject. I can fixup when applying, but I'd >> like an ack from Chris on patch 1. Sorry about that - I'll try to be more c

Re: [PATCH v3 2/2] drm/panfrost: Use drm_gem_shmem_map_offset()

2019-05-21 Thread Chris Wilson
Quoting Rob Herring (2019-05-21 16:24:27) > On Mon, May 20, 2019 at 4:23 AM Steven Price wrote: > > > > You forgot to update the subject. I can fixup when applying, but I'd > like an ack from Chris on patch 1. I still think it is incorrect as the limitation is purely an issue with the shmem back

Re: [PATCH v3 2/2] drm/panfrost: Use drm_gem_shmem_map_offset()

2019-05-21 Thread Rob Herring
On Mon, May 20, 2019 at 4:23 AM Steven Price wrote: > You forgot to update the subject. I can fixup when applying, but I'd like an ack from Chris on patch 1. > panfrost_ioctl_mmap_bo() contains a reimplementation of > drm_gem_map_offset() but with a bug - it allows mapping imported objects > (wi