Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-06 Thread Abhinav Kumar
On 12/5/2023 7:51 PM, Bjorn Andersson wrote: On Mon, Dec 04, 2023 at 11:22:24AM -0800, Abhinav Kumar wrote: On 12/3/2023 7:31 PM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: On 12/1/2023 8:22 AM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at 1

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-05 Thread Bjorn Andersson
On Mon, Dec 04, 2023 at 11:22:24AM -0800, Abhinav Kumar wrote: > > > On 12/3/2023 7:31 PM, Bjorn Andersson wrote: > > On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: > > > > > > > > > On 12/1/2023 8:22 AM, Bjorn Andersson wrote: > > > > On Fri, Dec 01, 2023 at 10:34:50AM +0200, D

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-04 Thread Abhinav Kumar
On 12/3/2023 7:31 PM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: On 12/1/2023 8:22 AM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson wrote: On Thu, Nov 30,

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-03 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: > > > On 12/1/2023 8:22 AM, Bjorn Andersson wrote: > > On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: > > > On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson > > > wrote: > > > > On Thu, Nov 30, 2023 at 05:40:55PM -080

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-01 Thread Abhinav Kumar
On 12/1/2023 8:22 AM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson wrote: On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote: [..] @@ -2386,6 +2390,7 @@ struct drm_encoder *dpu_encoder_in

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-01 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: > On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson > wrote: > > On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote: [..] > > > @@ -2386,6 +2390,7 @@ struct drm_encoder *dpu_encoder_init(struct > > > drm_device *dev, > > >

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-01 Thread Dmitry Baryshkov
On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson wrote: > > On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote: > > Add a missing mutex lock to control vblank irq. Thus prevent race > > conditions when registering/unregistering the irq callback. > > > > I'm guessing that the mutex is need

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-11-30 Thread Bjorn Andersson
On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote: > Add a missing mutex lock to control vblank irq. Thus prevent race > conditions when registering/unregistering the irq callback. > I'm guessing that the mutex is needed because vblank_refcount, while being an atomic_t, doesn't actu

[PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-11-30 Thread Paloma Arellano
Add a missing mutex lock to control vblank irq. Thus prevent race conditions when registering/unregistering the irq callback. v2: Slightly changed wording of commit message v3: Mistakenly did not change wording in last version. It is done now. Signed-off-by: Paloma Arellano --- drivers/gpu/drm/