Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-26 Thread Daniel Vetter
On Thu, Feb 23, 2017 at 10:02:26AM +0100, Stefan Lengfeld wrote: > Hi Maxime, Hi Ville, > > On Wed, Feb 22, 2017 at 04:52:33PM -0800, Maxime Ripard wrote: > > Hi Ville, Stefan, > > > > On Tue, Feb 21, 2017 at 12:55:01PM +0200, Ville Syrjälä wrote: > > > On Tue, Feb 21, 2017 at 11:00:59AM +0100, S

Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-23 Thread Stefan Lengfeld
Hi Maxime, Hi Ville, On Wed, Feb 22, 2017 at 04:52:33PM -0800, Maxime Ripard wrote: > Hi Ville, Stefan, > > On Tue, Feb 21, 2017 at 12:55:01PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 21, 2017 at 11:00:59AM +0100, Stefan Lengfeld wrote: > > > > > > Furthmore most exiting userspace code just p

Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-22 Thread Maxime Ripard
Hi Ville, Stefan, On Tue, Feb 21, 2017 at 12:55:01PM +0200, Ville Syrjälä wrote: > On Tue, Feb 21, 2017 at 11:00:59AM +0100, Stefan Lengfeld wrote: > > Hi Maxime, > > > > On Wed, Feb 15, 2017 at 05:19:09PM +0100, Maxime Ripard wrote: > > > From: Stefan Christ > > > > > > > Maybe change the aut

Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-21 Thread Michel Dänzer
On 21/02/17 07:00 PM, Stefan Lengfeld wrote: > > 2/ Wait for a single vsync event on all active crtcs as Ville Syrjälä >described here [2] in the optimal implementation. FWIW, this seems like a bad idea, since with multiple active CRTCs it would make it essentially random at which intervals

Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-21 Thread Ville Syrjälä
On Tue, Feb 21, 2017 at 11:00:59AM +0100, Stefan Lengfeld wrote: > Hi Maxime, > > On Wed, Feb 15, 2017 at 05:19:09PM +0100, Maxime Ripard wrote: > > From: Stefan Christ > > > > Maybe change the author here. Only the boilerplate code looks my original > patch. The real code is your work ;-) > >

Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-21 Thread Stefan Lengfeld
Hi Maxime, On Wed, Feb 15, 2017 at 05:19:09PM +0100, Maxime Ripard wrote: > From: Stefan Christ > Maybe change the author here. Only the boilerplate code looks my original patch. The real code is your work ;-) > Implement legacy framebuffer ioctl FBIO_WAITFORVSYNC in the generic > framebuffer

[PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-15 Thread Maxime Ripard
From: Stefan Christ Implement legacy framebuffer ioctl FBIO_WAITFORVSYNC in the generic framebuffer emulation driver. Legacy framebuffer users like non kms/drm based OpenGL(ES)/EGL implementations may require the ioctl to synchronize drawing or buffer flip for double buffering. It is tested on th