Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
On Fri, Aug 2, 2024 at 4:37 PM Harry Wentland wrote: > > On 2024-08-02 09:28, Sebastian Wick wrote: > > I'm very unhappy about how this has played out. > > > > We have a new sysfs property that controls a feature of the display > > path that has been set to a default(!) which changes the color > >

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Harry Wentland
On 2024-08-02 09:28, Sebastian Wick wrote: > I'm very unhappy about how this has played out. > > We have a new sysfs property that controls a feature of the display > path that has been set to a default(!) which changes the color > behavior! This broke color management for everyone who is on a dev

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
I'm very unhappy about how this has played out. We have a new sysfs property that controls a feature of the display path that has been set to a default(!) which changes the color behavior! This broke color management for everyone who is on a device which supports this feature. What should have be

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Xaver Hugl
Am Do., 1. Aug. 2024 um 14:34 Uhr schrieb Jani Nikula : > > On Mon, 01 Jul 2024, Xaver Hugl wrote: > > Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl > > : > >> Merging can only happen once a real world userspace application has > >> implemented support for it. I'll try to do that sometime

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-01 Thread Jani Nikula
On Thu, 01 Aug 2024, Thomas Zimmermann wrote: > Hi > > Am 01.08.24 um 14:33 schrieb Jani Nikula: >> On Mon, 01 Jul 2024, Xaver Hugl wrote: >>> Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl >>> : Merging can only happen once a real world userspace application has implemented sup

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-01 Thread Thomas Zimmermann
Hi Am 01.08.24 um 14:33 schrieb Jani Nikula: On Mon, 01 Jul 2024, Xaver Hugl wrote: Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl : Merging can only happen once a real world userspace application has implemented support for it. I'll try to do that sometime next week in KWin Here's th

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-01 Thread Jani Nikula
On Mon, 01 Jul 2024, Xaver Hugl wrote: > Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl : >> Merging can only happen once a real world userspace application has >> implemented support for it. I'll try to do that sometime next week in >> KWin > > Here's the promised implementation: > https:/

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-07-02 Thread Mario Limonciello
On 7/1/2024 17:34, Xaver Hugl wrote: Am Mo., 1. Juli 2024 um 21:02 Uhr schrieb Mario Limonciello : Hmm I'm a bit surprised the IGT tests I did didn't catch this. Are you working on a system with two GPUs by chance (like a Framework 16)? If so; can you try the "other GPU"? No, I tested on a F

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-07-01 Thread Xaver Hugl
Am Mo., 1. Juli 2024 um 21:02 Uhr schrieb Mario Limonciello : > Hmm I'm a bit surprised the IGT tests I did didn't catch this. > > Are you working on a system with two GPUs by chance (like a Framework > 16)? If so; can you try the "other GPU"? No, I tested on a Framework 13. > As it seems your P

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-07-01 Thread Mario Limonciello
On 7/1/2024 13:47, Xaver Hugl wrote: Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl : Merging can only happen once a real world userspace application has implemented support for it. I'll try to do that sometime next week in KWin Here's the promised implementation: https://invent.kde.org

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-07-01 Thread Xaver Hugl
Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl : > Merging can only happen once a real world userspace application has > implemented support for it. I'll try to do that sometime next week in > KWin Here's the promised implementation: https://invent.kde.org/plasma/kwin/-/merge_requests/6028

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-20 Thread Xaver Hugl
Am Mi., 19. Juni 2024 um 06:08 Uhr schrieb Mario Limonciello > Thanks! I don't have permissions, so can you (or someone else) please > apply to drm-misc-next for me? > > After it's merged I'll rebase and work on the feedback for the new IGT > tests. Merging can only happen once a real world user

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Mario Limonciello
On 6/18/2024 17:36, Leo Li wrote: On 2024-06-05 22:04, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Leo Li
On 2024-06-05 22:04, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask "Req

[PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-05 Thread Mario Limonciello
When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask "Require low latency" PSR should be disabled. When the