Re: [PATCH v3 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors

2021-06-25 Thread Lee Jones
On Thu, 24 Jun 2021, Uwe Kleine-König wrote: > Hi Lee, > > On Tue, Jun 22, 2021 at 02:12:57PM +0100, Lee Jones wrote: > > On Mon, 21 Jun 2021, Uwe Kleine-König wrote: > > > > > The practical upside here is that this only needs a single API call to > > > program the hardware which (depending on t

Re: [PATCH v3 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors

2021-06-24 Thread Uwe Kleine-König
Hi Lee, On Tue, Jun 22, 2021 at 02:12:57PM +0100, Lee Jones wrote: > On Mon, 21 Jun 2021, Uwe Kleine-König wrote: > > > The practical upside here is that this only needs a single API call to > > program the hardware which (depending on the underlaying hardware) can > > be more effective and preve

Re: [PATCH v3 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors

2021-06-22 Thread Lee Jones
On Mon, 21 Jun 2021, Uwe Kleine-König wrote: > The practical upside here is that this only needs a single API call to > program the hardware which (depending on the underlaying hardware) can > be more effective and prevents glitches. > > Up to now the return value of the pwm functions was ignored

Re: [PATCH v3 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors

2021-06-21 Thread Daniel Thompson
On Mon, Jun 21, 2021 at 02:21:48PM +0200, Uwe Kleine-König wrote: > The practical upside here is that this only needs a single API call to > program the hardware which (depending on the underlaying hardware) can > be more effective and prevents glitches. > > Up to now the return value of the pwm f

[PATCH v3 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors

2021-06-21 Thread Uwe Kleine-König
The practical upside here is that this only needs a single API call to program the hardware which (depending on the underlaying hardware) can be more effective and prevents glitches. Up to now the return value of the pwm functions was ignored. Fix this and propagate the error to the caller. Signe