Re: [PATCH v3 15/24] drm/rockchip: dw-mipi-dsi: configure PHY before enabling

2017-01-31 Thread John Keeping
On Mon, 30 Jan 2017 15:28:08 -0500, Sean Paul wrote: > On Sun, Jan 29, 2017 at 01:24:35PM +, John Keeping wrote: > > The bias, bandgap and PLL should all be configured before we enable > > them. > > > > Do you know why the test codes are hard-coded magic? It'd be nice to make some > sense

Re: [PATCH v3 15/24] drm/rockchip: dw-mipi-dsi: configure PHY before enabling

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:35PM +, John Keeping wrote: > The bias, bandgap and PLL should all be configured before we enable > them. > Do you know why the test codes are hard-coded magic? It'd be nice to make some sense of them in a future patch. Reviewed-by: Sean Paul > Signed-off-by:

[PATCH v3 15/24] drm/rockchip: dw-mipi-dsi: configure PHY before enabling

2017-01-29 Thread John Keeping
The bias, bandgap and PLL should all be configured before we enable them. Signed-off-by: John Keeping --- v3: - Squash together two patches that both affect initialization order of the PHY Unchanged in v2 drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 11 ++- 1 file changed, 6 insertions(+)