Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-03-23 Thread Vinod Koul
On 22-03-22, 19:59, Marijn Suijten wrote: > On 2022-03-22 22:46:50, Vinod Koul wrote: > > On 17-02-22, 16:11, Marijn Suijten wrote: > > > Hi Vinod, > > > > > > Thanks for taking time to go through this review, please find some > > > clarifications below. > > > > > > On 2022-02-17 16:44:04, Vinod

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-03-22 Thread Marijn Suijten
On 2022-03-22 22:46:50, Vinod Koul wrote: > On 17-02-22, 16:11, Marijn Suijten wrote: > > Hi Vinod, > > > > Thanks for taking time to go through this review, please find some > > clarifications below. > > > > On 2022-02-17 16:44:04, Vinod Koul wrote: > > > Hi Marijn, > > > > > > On 11-12-21, 01:

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-03-22 Thread Vinod Koul
On 17-02-22, 16:11, Marijn Suijten wrote: > Hi Vinod, > > Thanks for taking time to go through this review, please find some > clarifications below. > > On 2022-02-17 16:44:04, Vinod Koul wrote: > > Hi Marijn, > > > > On 11-12-21, 01:03, Marijn Suijten wrote: > > > > > > +static int dsi_dsc_upd

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-02-17 Thread Marijn Suijten
Hi Vinod, Thanks for taking time to go through this review, please find some clarifications below. On 2022-02-17 16:44:04, Vinod Koul wrote: > Hi Marijn, > > On 11-12-21, 01:03, Marijn Suijten wrote: > > > > +static int dsi_dsc_update_pic_dim(struct msm_display_dsc_config *dsc, > > > +

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-02-17 Thread Vinod Koul
Hi Marijn, On 11-12-21, 01:03, Marijn Suijten wrote: > > +static int dsi_dsc_update_pic_dim(struct msm_display_dsc_config *dsc, > > + int pic_width, int pic_height) > > This function - adopted from downstream - does not seem to perform a > whole lot, especially withou

Re: [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2021-12-10 Thread Marijn Suijten
Hi Vinod, On 2021-11-16 11:52:55, Vinod Koul wrote: > When DSC is enabled, we need to configure DSI registers accordingly and > configure the respective stream compression registers. > > Add support to calculate the register setting based on DSC params and > timing information and configure these

Re: [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2021-11-24 Thread Dmitry Baryshkov
On 24/11/2021 19:21, Dmitry Baryshkov wrote: On 16/11/2021 09:22, Vinod Koul wrote: When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing informa

Re: [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-of

Re: [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2021-11-18 Thread kernel test robot
Hi Vinod, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on v5.16-rc1 next-2028] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

[PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2021-11-15 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Vinod Koul --- drivers/gpu/drm/ms