Re: [PATCH v3 12/12] drm/bridge: tc358768: Attempt to fix DSI horizontal timings

2023-09-05 Thread Tomi Valkeinen
On 04/09/2023 21:46, Marcel Ziswiler wrote: Hi Tomi Looks good. Thanks! Tested both on Verdin AM62 as well as on Verdin iMX8M Mini. Just a minor nit-pick in your code comment further below. On Tue, 2023-08-22 at 19:19 +0300, Tomi Valkeinen wrote: The DSI horizontal timing calculations done by

Re: [PATCH v3 12/12] drm/bridge: tc358768: Attempt to fix DSI horizontal timings

2023-09-04 Thread Marcel Ziswiler
Hi Tomi Looks good. Thanks! Tested both on Verdin AM62 as well as on Verdin iMX8M Mini. Just a minor nit-pick in your code comment further below. On Tue, 2023-08-22 at 19:19 +0300, Tomi Valkeinen wrote: > The DSI horizontal timing calculations done by the driver seem to often > lead to underflow

[PATCH v3 12/12] drm/bridge: tc358768: Attempt to fix DSI horizontal timings

2023-08-22 Thread Tomi Valkeinen
The DSI horizontal timing calculations done by the driver seem to often lead to underflows or overflows, depending on the videomode. There are two main things the current driver doesn't seem to get right: DSI HSW and HFP, and VSDly. However, even following Toshiba's documentation it seems we don't