Re: [PATCH v3 10/10] drm/rockchip: Remove unnecessary NULL check

2017-03-21 Thread Thierry Reding
On Tue, Mar 21, 2017 at 11:27:04AM +0100, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 09:13:58AM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > The expression &private->fbdev_helper can never be NULL, so the check is > > completely unnecessary. > > > > Signed-off-by: Thierry Re

Re: [PATCH v3 10/10] drm/rockchip: Remove unnecessary NULL check

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:13:58AM +0100, Thierry Reding wrote: > From: Thierry Reding > > The expression &private->fbdev_helper can never be NULL, so the check is > completely unnecessary. > > Signed-off-by: Thierry Reding On the 3 drivers patches (all except exynos): Reviewed-by: Daniel Vet

[PATCH v3 10/10] drm/rockchip: Remove unnecessary NULL check

2017-03-21 Thread Thierry Reding
From: Thierry Reding The expression &private->fbdev_helper can never be NULL, so the check is completely unnecessary. Signed-off-by: Thierry Reding --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/roc