Re: [PATCH v3 1/7] drm/msm: adreno: add defines for gpu & gmu frequency table sizes

2024-11-30 Thread Akhil P Oommen
On 11/28/2024 3:55 PM, Neil Armstrong wrote: > Even if the code uses ARRAY_SIZE() to fill those tables, > it's still a best practice to not use magic values for > tables in structs. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Neil Armstrong Reviewed-by: Akhil P Oommen -Akhil > --- >

Re: [PATCH v3 1/7] drm/msm: adreno: add defines for gpu & gmu frequency table sizes

2024-11-28 Thread Dmitry Baryshkov
On Thu, Nov 28, 2024 at 11:25:41AM +0100, Neil Armstrong wrote: > Even if the code uses ARRAY_SIZE() to fill those tables, > it's still a best practice to not use magic values for > tables in structs. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/msm

[PATCH v3 1/7] drm/msm: adreno: add defines for gpu & gmu frequency table sizes

2024-11-28 Thread Neil Armstrong
Even if the code uses ARRAY_SIZE() to fill those tables, it's still a best practice to not use magic values for tables in structs. Suggested-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletion