Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Duje Mihanović
On Monday, January 22, 2024 6:50:31 PM CET Daniel Thompson wrote: > On Mon, Jan 22, 2024 at 06:26:04PM +0100, Duje Mihanović wrote: > > On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > > > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > > > AFAICT nothing wil

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Daniel Thompson
On Mon, Jan 22, 2024 at 06:26:04PM +0100, Duje Mihanović wrote: > On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > > AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig > > > builds will al

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Duje Mihanović
On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig > > builds will always end up with GPIOLIB enabled. If we are happy to > > select it then

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Duje Mihanović
On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > On Mon, Jan 22, 2024 at 05:24:51PM +0100, Duje Mihanović wrote: > > I believe a "select" would be more appropriate here unless these backlights > > should be hidden if GPIOLIB is disabled. The catch with "select" is that > > there

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Daniel Thompson
On Mon, Jan 22, 2024 at 05:24:51PM +0100, Duje Mihanović wrote: > On Monday, January 22, 2024 11:19:26 AM CET Daniel Thompson wrote: > > On Sat, Jan 20, 2024 at 10:26:43PM +0100, Duje Mihanović wrote: > > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > > > index 6292fddcc55c..d29b6823e

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Duje Mihanović
On Monday, January 22, 2024 11:19:26 AM CET Daniel Thompson wrote: > On Sat, Jan 20, 2024 at 10:26:43PM +0100, Duje Mihanović wrote: > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > > index 6292fddcc55c..d29b6823e7d1 100644 > > --- a/drivers/leds/Kconfig > > +++ b/drivers/leds/Kconfig

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Daniel Thompson
On Sat, Jan 20, 2024 at 10:26:43PM +0100, Duje Mihanović wrote: > The ExpressWire protocol is shared between at least KTD2692 and KTD2801 > with slight differences such as timings and the former not having a > defined set of pulses for enabling the protocol (possibly because it > does not support P

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-21 Thread Duje Mihanović
On Sunday, January 21, 2024 3:35:46 PM CET Linus Walleij wrote: > > +extern void expresswire_power_off(struct expresswire_common_props *props); > > +extern void expresswire_enable(struct expresswire_common_props *props); > > +extern void expresswire_start(struct expresswire_common_props *props); >

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-21 Thread Linus Walleij
On Sat, Jan 20, 2024 at 10:27 PM Duje Mihanović wrote: > The ExpressWire protocol is shared between at least KTD2692 and KTD2801 > with slight differences such as timings and the former not having a > defined set of pulses for enabling the protocol (possibly because it > does not support PWM unli

[PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-20 Thread Duje Mihanović
The ExpressWire protocol is shared between at least KTD2692 and KTD2801 with slight differences such as timings and the former not having a defined set of pulses for enabling the protocol (possibly because it does not support PWM unlike KTD2801). Despite these differences the ExpressWire handling c