Re: [PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Alyssa Rosenzweig
> Sorry about this blunder. > > >> + slot = panfrost_job_get_slot(job); > >> + slot = slot ? slot : 0; > > > >`slot = slot ? slot : 0` is a no-op. Delete the line. > > I think what I meant here was 'slot = (slot >= 0) ? slot : 0;' but for some > reason I blundered again. The point of this was e

Re: [PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Adri??n Larumbe
On 22.06.2022 08:17, Alyssa Rosenzweig wrote: >> +js_as_offset = slot * 0x80; > >JS_SLOT_STRIDE Sorry about this blunder. >> +slot = panfrost_job_get_slot(job); >> +slot = slot ? slot : 0; > >`slot = slot ? slot : 0` is a no-op. Delete the line. I think what I meant h

Re: [PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread kernel test robot
Hi "Adrián, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on linus/master v5.19-rc3 next-20220622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--ba

Re: [PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Alyssa Rosenzweig
> + js_as_offset = slot * 0x80; JS_SLOT_STRIDE > + slot = panfrost_job_get_slot(job); > + slot = slot ? slot : 0; `slot = slot ? slot : 0` is a no-op. Delete the line. > + if (!IS_ERR(page)) > + *bomap++ = cpu_to_le64(p

[PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-21 Thread Adrián Larumbe
In the event of a job timeout, debug dump information will be written into /sys/class/devcoredump. Inspired by etnaviv's similar feature. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/Kconfig | 1 + drivers/gpu/drm/panfrost/Makefile| 3 +- drivers/gpu/drm/panfro