Re: [PATCH v3 09/17] drm/imagination: Implement power management

2023-07-14 Thread Frank Binns
Hi Maxime, On Fri, 2023-07-07 at 14:48 +0200, Maxime Ripard wrote: > On Tue, Jun 13, 2023 at 03:47:52PM +0100, Sarah Walker wrote: > > @@ -503,21 +506,31 @@ pvr_device_init(struct pvr_device *pvr_dev) > > if (err) > > goto err_device_clk_fini; > > > > + /* Explicitly power

Re: [PATCH v3 09/17] drm/imagination: Implement power management

2023-07-07 Thread Maxime Ripard
On Tue, Jun 13, 2023 at 03:47:52PM +0100, Sarah Walker wrote: > @@ -503,21 +506,31 @@ pvr_device_init(struct pvr_device *pvr_dev) > if (err) > goto err_device_clk_fini; > > + /* Explicitly power the GPU so we can access control registers before > the FW is booted. */ > +

[PATCH v3 09/17] drm/imagination: Implement power management

2023-06-13 Thread Sarah Walker
Add power management to the driver, using runtime pm. The power off sequence depends on firmware commands which are not implemented in this patch. Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile | 1 + drivers/gpu/drm/imagination/pvr_device.c | 20 +- drivers/gpu/drm/