On 15.02.2019 20:36, Vasily Khoruzhick wrote:
> On Fri, Feb 15, 2019 at 1:13 AM Andrzej Hajda wrote:
>
> Hi Andrzej,
>
> Thanks for review!
>
>>> +#include
>> Do you need this header?
> I'll drop it.
>
>>> +#include
>> drmP.h is/should be deprecated.
> Same here
>
>>> +struct anx6345_platform_da
On Thu, Feb 14, 2019 at 09:09:51PM -0800, Vasily Khoruzhick wrote:
> From: Icenowy Zheng
>
> The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed
> for portable devices. This driver adds initial support for RGB to eDP
> mode, without HPD and interrupts.
>
> This is a configura
On Fri, Feb 15, 2019 at 12:23 AM Priit Laes wrote:
> > + err = anx6345_tx_initialization(anx6345);
> > + if (err) {
> > + DRM_ERROR("Failed transmitter initialization: %d\n", err);
> > + goto err_poweroff;
>
> You can move the whole err_poweroff section from below
On Fri, Feb 15, 2019 at 1:13 AM Andrzej Hajda wrote:
Hi Andrzej,
Thanks for review!
> > +#include
> Do you need this header?
I'll drop it.
> > +#include
>
> drmP.h is/should be deprecated.
Same here
> > +struct anx6345_platform_data {
> > + struct regulator *dvdd12;
> > + struct r
From: Icenowy Zheng
The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed
for portable devices. This driver adds initial support for RGB to eDP
mode, without HPD and interrupts.
This is a configuration usually seen in eDP applications.
Signed-off-by: Icenowy Zheng
Signed-off-
On 15.02.2019 06:09, Vasily Khoruzhick wrote:
> From: Icenowy Zheng
>
> The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed
> for portable devices. This driver adds initial support for RGB to eDP
> mode, without HPD and interrupts.
>
> This is a configuration usually seen in eD
