Re: [PATCH v3 02/10] drm/rcar-du: Write DPTSR only if the second source exists

2024-12-09 Thread Laurent Pinchart
On Tue, Dec 10, 2024 at 01:04:19AM +0200, Laurent Pinchart wrote: > On Fri, Dec 06, 2024 at 11:32:35AM +0200, Tomi Valkeinen wrote: > > From: Tomi Valkeinen > > > > Currently the driver always writes DPTSR when setting up the hardware. > > However, writing the register is only meaningful when the

Re: [PATCH v3 02/10] drm/rcar-du: Write DPTSR only if the second source exists

2024-12-09 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Dec 06, 2024 at 11:32:35AM +0200, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Currently the driver always writes DPTSR when setting up the hardware. > However, writing the register is only meaningful when the second source > for a plane is used, an

[PATCH v3 02/10] drm/rcar-du: Write DPTSR only if the second source exists

2024-12-06 Thread Tomi Valkeinen
From: Tomi Valkeinen Currently the driver always writes DPTSR when setting up the hardware. However, writing the register is only meaningful when the second source for a plane is used, and the register is not even documented for SoCs that do not have the second source. So move the write behind a