Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Laurent Pinchart
Hi Shawn, Thank you for the patch. On Tuesday 07 Feb 2017 17:16:13 Shawn Guo wrote: > From: Shawn Guo > > The vblank is mostly CRTC specific and implemented as part of CRTC > driver. Let's keep the vblank hooks struct drm_driver for legacy > drivers, and add corresponding hooks in struct drm_c

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 11:52:06AM +0100, Daniel Vetter wrote: > On Tue, Feb 07, 2017 at 11:38:08AM +0100, Andrzej Hajda wrote: > > On 07.02.2017 10:16, Shawn Guo wrote: > > > +static u32 __get_vblank_counter(struct drm_device *dev, unsigned int > > > pipe) > > > +{ > > > + if (drm_core_check_feat

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 05:16:13PM +0800, Shawn Guo wrote: > From: Shawn Guo > > The vblank is mostly CRTC specific and implemented as part of CRTC > driver. Let's keep the vblank hooks struct drm_driver for legacy > drivers, and add corresponding hooks in struct drm_crtc_funcs. These > hooks t

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 11:38:08AM +0100, Andrzej Hajda wrote: > On 07.02.2017 10:16, Shawn Guo wrote: > > +static u32 __get_vblank_counter(struct drm_device *dev, unsigned int pipe) > > +{ > > + if (drm_core_check_feature(dev, DRIVER_MODESET)) { > > + struct drm_crtc *crtc = drm_crtc_f

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Andrzej Hajda
On 07.02.2017 10:16, Shawn Guo wrote: > From: Shawn Guo > > The vblank is mostly CRTC specific and implemented as part of CRTC > driver. Let's keep the vblank hooks struct drm_driver for legacy > drivers, and add corresponding hooks in struct drm_crtc_funcs. These > hooks take struct drm_crtc po

[PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank is mostly CRTC specific and implemented as part of CRTC driver. Let's keep the vblank hooks struct drm_driver for legacy drivers, and add corresponding hooks in struct drm_crtc_funcs. These hooks take struct drm_crtc pointer as argument, and will be called by core vbl