Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Sam Ravnborg
Hi Geert. > > > > > > Yeah I don't think we should describe these with bpp or cpp or anything > > > like that. bpp < 8 makes sense since that's how this has been done since > > > decades, but trying to extend these to funny new formats is a bad idea. > > > This is also why cpp and depth refuse to

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Geert Uytterhoeven
Hi Sam, On Thu, Aug 11, 2022 at 8:29 PM Sam Ravnborg wrote: > On Thu, Aug 11, 2022 at 06:11:40PM +0200, Daniel Vetter wrote: > > On Thu, Aug 11, 2022 at 09:59:39AM +0200, Geert Uytterhoeven wrote: > > > On Wed, Aug 10, 2022 at 5:59 PM Daniel Vetter wrote: > > > > On Fri, Jul 08, 2022 at 08:20:46

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Sam Ravnborg
Hi Geert, Daniel. On Thu, Aug 11, 2022 at 06:11:40PM +0200, Daniel Vetter wrote: > On Thu, Aug 11, 2022 at 09:59:39AM +0200, Geert Uytterhoeven wrote: > > Hi Daniel, > > > > On Wed, Aug 10, 2022 at 5:59 PM Daniel Vetter wrote: > > > On Fri, Jul 08, 2022 at 08:20:46PM +0200, Geert Uytterhoeven wr

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Daniel Vetter
On Thu, Aug 11, 2022 at 09:59:39AM +0200, Geert Uytterhoeven wrote: > Hi Daniel, > > On Wed, Aug 10, 2022 at 5:59 PM Daniel Vetter wrote: > > On Fri, Jul 08, 2022 at 08:20:46PM +0200, Geert Uytterhoeven wrote: > > > Add a helper to retrieve the actual number of bits per pixel for a > > > plane, t

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Geert Uytterhoeven
Hi Daniel, On Wed, Aug 10, 2022 at 5:59 PM Daniel Vetter wrote: > On Fri, Jul 08, 2022 at 08:20:46PM +0200, Geert Uytterhoeven wrote: > > Add a helper to retrieve the actual number of bits per pixel for a > > plane, taking into account the number of characters and pixels per > > block for tiled f

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-10 Thread Daniel Vetter
On Fri, Jul 08, 2022 at 08:20:46PM +0200, Geert Uytterhoeven wrote: > Add a helper to retrieve the actual number of bits per pixel for a > plane, taking into account the number of characters and pixels per > block for tiled formats. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Javier Mart

[PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-07-08 Thread Geert Uytterhoeven
Add a helper to retrieve the actual number of bits per pixel for a plane, taking into account the number of characters and pixels per block for tiled formats. Signed-off-by: Geert Uytterhoeven Reviewed-by: Javier Martinez Canillas --- v3: - Add Reviewed-by, v2: - Move up. --- drivers/gpu/d