Re: [PATCH v3 0/4] drm/i915: Fix harmfull driver register/unregister assymetry

2025-03-06 Thread Krzysztof Karas
Hi Janusz, thanks for a quick response. > > throughout the series you modify the code right after > > introducing it. > > Yes, that split among patches reflects my way of getting to a solution that > not only resolves the issue but also tries to address comments I got and take > care of resul

Re: [PATCH v3 0/4] drm/i915: Fix harmfull driver register/unregister assymetry

2025-03-06 Thread Janusz Krzysztofik
Hi Krzysztof, Thank you for looking at it. On Thursday, 6 March 2025 12:00:40 CET Krzysztof Karas wrote: > Hi Janusz, > > throughout the series you modify the code right after > introducing it. Yes, that split among patches reflects my way of getting to a solution that not only resolves the i

Re: [PATCH v3 0/4] drm/i915: Fix harmfull driver register/unregister assymetry

2025-03-06 Thread Krzysztof Karas
Hi Janusz, throughout the series you modify the code right after introducing it. How about changing the order of things a bit: 1) order the functions in a symmetrical way between register/unregister steps and group them as you see necessary, (At that point you would not be fixing the issue ye

[PATCH v3 0/4] drm/i915: Fix harmfull driver register/unregister assymetry

2025-03-05 Thread Janusz Krzysztofik
Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if drm_dev_register() fails"), we may return from i915_driver_register() immediately, skipping remaining registration steps. However, the _unregister() counterpart called at device remove knows nothing about that skip and executes reve