Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Michal Suchánek
On Wed, Feb 23, 2022 at 07:34:54PM +0100, Javier Martinez Canillas wrote: > On 2/23/22 19:23, Michal Suchánek wrote: > > [snip] > > >> My point about the subject line remains thought, I would use something > >> like: > >> > >> firmware: sysfb: Enable boot time VESA graphic mode selection for sim

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Javier Martinez Canillas
On 2/23/22 19:23, Michal Suchánek wrote: [snip] >> My point about the subject line remains thought, I would use something like: >> >> firmware: sysfb: Enable boot time VESA graphic mode selection for simplefb > > I see where the confusion comes from. > Yeah. And just to clarify, the "simplefb"

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Michal Suchánek
On Wed, Feb 23, 2022 at 07:13:07PM +0100, Javier Martinez Canillas wrote: > On 2/23/22 18:12, Michal Suchánek wrote: > > On Wed, Feb 23, 2022 at 05:54:54PM +0100, Javier Martinez Canillas wrote: > > [snip] > > >> > >> Yes, that's what I tried to say. But your commit message says "To enable > >> u

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Javier Martinez Canillas
On 2/23/22 18:12, Michal Suchánek wrote: > On Wed, Feb 23, 2022 at 05:54:54PM +0100, Javier Martinez Canillas wrote: [snip] >> >> Yes, that's what I tried to say. But your commit message says "To enable >> use of VESA modes with simplefb in legacy BIOS boot mode" and that isn't >> accurate AFAIU

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Michal Suchánek
On Wed, Feb 23, 2022 at 05:54:54PM +0100, Javier Martinez Canillas wrote: > On 2/23/22 17:45, Michal Suchánek wrote: > > [snip] > > >>> > >>> To enable use of VESA modes with simplefb in legacy BIOS boot mode drop > >> > >> I think you meant "VESA modes with the sysfb driver" ? or something like >

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Javier Martinez Canillas
On 2/23/22 17:54, Javier Martinez Canillas wrote: > On 2/23/22 17:45, Michal Suchánek wrote: > > [snip] > To enable use of VESA modes with simplefb in legacy BIOS boot mode drop >>> >>> I think you meant "VESA modes with the sysfb driver" ? or something like >>> that since otherwise it

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Javier Martinez Canillas
On 2/23/22 17:45, Michal Suchánek wrote: [snip] >>> >>> To enable use of VESA modes with simplefb in legacy BIOS boot mode drop >> >> I think you meant "VESA modes with the sysfb driver" ? or something like >> that since otherwise it seems that you meant to use it with the simplefb >> (drivers/vi

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Michal Suchánek
On Wed, Feb 23, 2022 at 05:34:50PM +0100, Javier Martinez Canillas wrote: > Hello Michal, > > On 2/18/22 17:04, Michal Suchanek wrote: > > Since switch to simplefb/simpledrm VESA graphic modes are no longer > > available with legacy BIOS. > > Maybe you can mention that is the "vga=" kernel comman

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-23 Thread Javier Martinez Canillas
Hello Michal, On 2/18/22 17:04, Michal Suchanek wrote: > Since switch to simplefb/simpledrm VESA graphic modes are no longer > available with legacy BIOS. > Maybe you can mention that is the "vga=" kernel command line parameter since that may be more evident to people reading the commit message ?

Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-21 Thread Thomas Zimmermann
Hi Am 18.02.22 um 17:04 schrieb Michal Suchanek: Since switch to simplefb/simpledrm VESA graphic modes are no longer available with legacy BIOS. The x86 realmode boot code enables the VESA graphic modes when option FB_BOOT_VESA_SUPPORT is enabled. To enable use of VESA modes with simplefb in l

[PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

2022-02-18 Thread Michal Suchanek
Since switch to simplefb/simpledrm VESA graphic modes are no longer available with legacy BIOS. The x86 realmode boot code enables the VESA graphic modes when option FB_BOOT_VESA_SUPPORT is enabled. To enable use of VESA modes with simplefb in legacy BIOS boot mode drop dependency of BOOT_VESA_SU