Re: [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-06 Thread Keith Packard
> Good questions! In general the audio functionalities should not > depend on the display activeness. There are even audio-only HDMI > devices. So I'll need to make intel_write_eld() work even without > information about the current display mode. Yeah, we'll need to figure out what the ELD shoul

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-06 Thread Keith Packard
> Good questions! In general the audio functionalities should not > depend on the display activeness. There are even audio-only HDMI > devices. So I'll need to make intel_write_eld() work even without > information about the current display mode. Yeah, we'll need to figure out what the ELD shoul

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-05 Thread Wu Fengguang
On Fri, Aug 05, 2011 at 02:03:41AM +0800, Keith Packard wrote: > On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang > wrote: > > > Right. I actually have this chunk. dmesg shows that in intel_hdmi_detect(), > > > > the drm_encoder object is there, however encoder->crtc is NULL at the > > time. >

RE: [alsa-devel] [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-05 Thread Stephen Warren
Wu Fengguang wrote at Friday, August 05, 2011 6:50 AM: > On Fri, Aug 05, 2011 at 02:03:41AM +0800, Keith Packard wrote: > > On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang > > wrote: ... > > > You may wonder why the mode parameter is needed in intel_write_eld(). > > > This is because the ELD fiel

[alsa-devel] [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-05 Thread Stephen Warren
Wu Fengguang wrote at Friday, August 05, 2011 6:50 AM: > On Fri, Aug 05, 2011 at 02:03:41AM +0800, Keith Packard wrote: > > On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang > > wrote: ... > > > You may wonder why the mode parameter is needed in intel_write_eld(). > > > This is because the ELD fiel

Re: [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-05 Thread Wu Fengguang
On Fri, Aug 05, 2011 at 02:03:41AM +0800, Keith Packard wrote: > On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang > wrote: > > > Right. I actually have this chunk. dmesg shows that in intel_hdmi_detect(), > > > > the drm_encoder object is there, however encoder->crtc is NULL at the > > time. >

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-04 Thread Wu Fengguang
> On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang > wrote: > > > 1) intel_write_eld() is not called at all > >It seems we need to call intel_write_eld() in other places besides > >inside ->mode_set(). Is ->detect() the right place to do so? In > >other words, are there established co

Re: [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-04 Thread Keith Packard
On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang wrote: > Right. I actually have this chunk. dmesg shows that in intel_hdmi_detect(), > the drm_encoder object is there, however encoder->crtc is NULL at the > time. Correct. encoder->crtc is set only when the output is active. > You may wonder w

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-04 Thread Keith Packard
On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang wrote: > Right. I actually have this chunk. dmesg shows that in intel_hdmi_detect(), > the drm_encoder object is there, however encoder->crtc is NULL at the > time. Correct. encoder->crtc is set only when the output is active. > You may wonder

Re: [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-04 Thread Wu Fengguang
> On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang > wrote: > > > 1) intel_write_eld() is not called at all > >It seems we need to call intel_write_eld() in other places besides > >inside ->mode_set(). Is ->detect() the right place to do so? In > >other words, are there established co

Re: [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-03 Thread Keith Packard
On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang wrote: > 1) intel_write_eld() is not called at all >It seems we need to call intel_write_eld() in other places besides >inside ->mode_set(). Is ->detect() the right place to do so? In >other words, are there established connector<=>encod

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-03 Thread Keith Packard
On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang wrote: > 1) intel_write_eld() is not called at all >It seems we need to call intel_write_eld() in other places besides >inside ->mode_set(). Is ->detect() the right place to do so? In >other words, are there established connector<=>enco

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-01 Thread Wu Fengguang
Hi Jesse, > On Wed, 29 Jun 2011 21:10:13 +0800 > Wu Fengguang wrote: > > > Update: according to the spec, limit max a/v latencies to 500ms and > > avoid overflowing the ELD field Aud_Synch_Delay[7:0]. > > > > Thanks to Pierre for pointing this out! > > > > btw, the drm_edid_to_eld() function r