Re: [PATCH v3] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines

2025-02-17 Thread Robert Foss
On Fri, 14 Feb 2025 18:46:32 +0300, Vitalii Mordan wrote: > If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not > be disabled in any path. > > The return value of clk_prepare_enable() is not checked. If mhdp->clk was > not enabled, it may be disabled in the error path of cdn

Re: [PATCH v3] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines

2025-02-14 Thread Dmitry Baryshkov
On Fri, Feb 14, 2025 at 06:46:32PM +0300, Vitalii Mordan wrote: > If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not > be disabled in any path. > > The return value of clk_prepare_enable() is not checked. If mhdp->clk was > not enabled, it may be disabled in the error path

[PATCH v3] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines

2025-02-14 Thread Vitalii Mordan
If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not be disabled in any path. The return value of clk_prepare_enable() is not checked. If mhdp->clk was not enabled, it may be disabled in the error path of cdns_mhdp_probe() (e.g., if cdns_mhdp_load_firmware() fails) or in cdns