Hi Russell
> > > This is wrong. If platform is NULL, PTR_ERR() will return zero, which
> > > will be interpreted as success. Please, avoid using IS_ERR_OR_NULL(),
> > > it leads to exactly this kind of cockup - and it's unnecessary here
> > > because platform_device_register_full() does not ret
On Mon, Nov 07, 2016 at 03:50:00AM +, Kuninori Morimoto wrote:
>
> Hi Russell
>
> > > + platform = platform_device_register_full(&pdevinfo);
> > > + if (IS_ERR_OR_NULL(platform))
> > > + return PTR_ERR(platform);
> >
> > This is wrong. If platform is NULL, PTR_ERR() will return zero
Hi Russell
> > + platform = platform_device_register_full(&pdevinfo);
> > + if (IS_ERR_OR_NULL(platform))
> > + return PTR_ERR(platform);
>
> This is wrong. If platform is NULL, PTR_ERR() will return zero, which
> will be interpreted as success. Please, avoid using IS_ERR_OR_NULL
On Wed, Nov 02, 2016 at 01:18:35AM +, Kuninori Morimoto wrote:
> + platform = platform_device_register_full(&pdevinfo);
> + if (IS_ERR_OR_NULL(platform))
> + return PTR_ERR(platform);
This is wrong. If platform is NULL, PTR_ERR() will return zero, which
will be interpreted
From: Kuninori Morimoto
Current dw-hdmi is supporting sound via AHB bus, but it has
I2S audio feature too. This patch adds I2S audio support to dw-hdmi.
This HDMI I2S is supported by using ALSA SoC common HDMI encoder
driver.
Tested-by: Jose Abreu
Signed-off-by: Kuninori Morimoto
---
v2 -> v3
