Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Salvatore Bonaccorso
Hi, On Thu, Feb 25, 2021 at 07:01:57PM +, Sudip Mukherjee wrote: > On Tue, Feb 23, 2021 at 02:09:58PM +0100, Greg KH wrote: > > On Tue, Feb 23, 2021 at 01:51:09PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 23.02.21 um 13:24 schrieb Greg KH: > > > > On Tue, Feb 23, 2021 at 01:14:3

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Sudip Mukherjee
On Tue, Feb 23, 2021 at 02:09:58PM +0100, Greg KH wrote: > On Tue, Feb 23, 2021 at 01:51:09PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 13:24 schrieb Greg KH: > > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 16:45 schrieb Alan Stern: On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -29,6 +29,7 @@ #include #include #include +#

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 18:30 schrieb Greg KH: On Tue, Feb 23, 2021 at 11:00:54AM -0500, Alan Stern wrote: On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: Hi Am 23.02.21 um 14:44 schrieb Takashi Iwai: Aside from the discussion whether this "workaround" is needed, the use of ud

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 11:00:54AM -0500, Alan Stern wrote: > On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 14:44 schrieb Takashi Iwai: > > > > Aside from the discussion whether this "workaround" is needed, the use > > > of udev->bus->controller

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Takashi Iwai
On Tue, 23 Feb 2021 17:00:54 +0100, Alan Stern wrote: > > On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 14:44 schrieb Takashi Iwai: > > > > Aside from the discussion whether this "workaround" is needed, the use > > > of udev->bus->controller her

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Alan Stern
On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: > Hi > > Am 23.02.21 um 14:44 schrieb Takashi Iwai: > > Aside from the discussion whether this "workaround" is needed, the use > > of udev->bus->controller here looks a bit suspicious. As the old USB > > code (before the commit 6

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Alan Stern
On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > --- a/drivers/gpu/drm/drm_prime.c > > +++ b/drivers/gpu/drm/drm_prime.c > > @@ -29,6 +29,7 @@ > > #include > > #include > > #include > > +#include > > > > #inc

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 14:44 schrieb Takashi Iwai: On Tue, 23 Feb 2021 11:58:42 +0100, Thomas Zimmermann wrote: USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Importing dmabuf into a USB-based driver fails, which break joining and mirroring of display in X1

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Takashi Iwai
On Tue, 23 Feb 2021 11:58:42 +0100, Thomas Zimmermann wrote: > > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Importing dmabuf into a USB-based driver fails, which > break joining and mirroring of display in X11. > > For USB devices, pick the associat

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 13:52 schrieb Greg KH: On Tue, Feb 23, 2021 at 01:49:50PM +0100, Daniel Vetter wrote: On Tue, Feb 23, 2021 at 1:44 PM Greg KH wrote: On Tue, Feb 23, 2021 at 01:37:09PM +0100, Thomas Zimmermann wrote: Hi Am 23.02.21 um 12:19 schrieb Greg KH: On Tue, Feb 23, 2021 at 11:58:

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:51:09PM +0100, Thomas Zimmermann wrote: > Hi > > Am 23.02.21 um 13:24 schrieb Greg KH: > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH > > > wrote: > > > > > > > > On Tue, Feb 23, 2021 at 12:46:20PM +010

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:50 PM Greg KH wrote: > > On Tue, Feb 23, 2021 at 01:40:51PM +0100, Daniel Vetter wrote: > > On Tue, Feb 23, 2021 at 1:24 PM Greg KH wrote: > > > > > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH > > > >

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:49:50PM +0100, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 1:44 PM Greg KH wrote: > > > > On Tue, Feb 23, 2021 at 01:37:09PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 23.02.21 um 12:19 schrieb Greg KH: > > > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Th

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 13:24 schrieb Greg KH: On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: On Tue, Feb 23, 2021 at 1:02 PM Greg KH wrote: On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: On Tue, Feb 23, 202

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:40:51PM +0100, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 1:24 PM Greg KH wrote: > > > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH > > > wrote: > > > > > > > > On Tue, Feb 23, 2021 at 12:46:20PM +01

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:44 PM Greg KH wrote: > > On Tue, Feb 23, 2021 at 01:37:09PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 12:19 schrieb Greg KH: > > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > > > USB devices cannot perform DMA and hence have

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:37 PM Thomas Zimmermann wrote: > > Hi > > Am 23.02.21 um 12:19 schrieb Greg KH: > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > >> USB devices cannot perform DMA and hence have no dma_mask set in their > >> device structure. Importing dmabuf into

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:37:09PM +0100, Thomas Zimmermann wrote: > Hi > > Am 23.02.21 um 12:19 schrieb Greg KH: > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > > USB devices cannot perform DMA and hence have no dma_mask set in their > > > device structure. Importing dm

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:24 PM Greg KH wrote: > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH wrote: > > > > > > On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 12:19 schrieb Greg KH: On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Importing dmabuf into a USB-based driver fails, which break joining and mirroring of display in X1

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 1:02 PM Greg KH wrote: > > > > On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: > > > On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > > > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Th

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:02 PM Greg KH wrote: > > On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: > > On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > > > USB devices cannot perform DMA and hence h

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > > USB devices cannot perform DMA and hence have no dma_mask set in their > > > device structure. Impor

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > USB devices cannot perform DMA and hence have no dma_mask set in their > > device structure. Importing dmabuf into a USB-based driver fails, which > > break joining and

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > USB devices cannot perform DMA and hence have no dma_mask set in their > > device structure. Importing dmabuf into a USB-based driver fails, which > > break joining and

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Importing dmabuf into a USB-based driver fails, which > break joining and mirroring of display in X11. > > For USB devices, pick the assoc

[PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Importing dmabuf into a USB-based driver fails, which break joining and mirroring of display in X11. For USB devices, pick the associated USB controller as attachment device, so that it can perform DMA. If the