Re: [PATCH v3] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Koenig, Christian
Am 26.09.19 um 15:43 schrieb Steven Price: > On 26/09/2019 14:37, Koenig, Christian wrote: >> Am 26.09.19 um 14:31 schrieb Steven Price: >>> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >>> it is called as the condition of wait_event_interruptible() it must not >>> sleep

Re: [PATCH v3] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Steven Price
On 26/09/2019 14:37, Koenig, Christian wrote: > Am 26.09.19 um 14:31 schrieb Steven Price: >> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >> it is called as the condition of wait_event_interruptible() it must not >> sleep. Unfortuantly some free callbacks (notibly for P

Re: [PATCH v3] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Koenig, Christian
Am 26.09.19 um 14:31 schrieb Steven Price: > drm_sched_cleanup_jobs() attempts to free finished jobs, however because > it is called as the condition of wait_event_interruptible() it must not > sleep. Unfortuantly some free callbacks (notibly for Panfrost) do sleep. > > Instead let's rename drm_sch

[PATCH v3] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Steven Price
drm_sched_cleanup_jobs() attempts to free finished jobs, however because it is called as the condition of wait_event_interruptible() it must not sleep. Unfortuantly some free callbacks (notibly for Panfrost) do sleep. Instead let's rename drm_sched_cleanup_jobs() to drm_sched_get_cleanup_job() and