Re: [PATCH v3] drm/vkms: Add overlay plane support

2019-03-14 Thread Rodrigo Siqueira
On 03/13, Mamta Shukla wrote: > On Sun, Mar 10, 2019 at 9:00 PM Rodrigo Siqueira > wrote: > > > > Hi, > > > > Thanks for your patch. > > > > You can see my comments inline. > > > > On 03/09, Mamta Shukla wrote: > > > Add overlay plane support in vkms aligned with cursor and primary > > > plane wit

Re: [PATCH v3] drm/vkms: Add overlay plane support

2019-03-13 Thread Mamta Shukla
On Sun, Mar 10, 2019 at 9:00 PM Rodrigo Siqueira wrote: > > Hi, > > Thanks for your patch. > > You can see my comments inline. > > On 03/09, Mamta Shukla wrote: > > Add overlay plane support in vkms aligned with cursor and primary > > plane with module option 'enable_overlay' to enable/disable ove

[PATCH v3] drm/vkms: Add overlay plane support

2019-03-11 Thread Mamta Shukla
Add overlay plane support in vkms aligned with cursor and primary plane with module option 'enable_overlay' to enable/disable overlay plane while testing. This currently passes plane-position-covered-pipe-A-plane subtest from IGT kms_plane test. Signed-off-by: Mamta Shukla --- changes in v3: -Fi

Re: [PATCH v3] drm/vkms: Add overlay plane support

2019-03-10 Thread Rodrigo Siqueira
Hi, Thanks for your patch. You can see my comments inline. On 03/09, Mamta Shukla wrote: > Add overlay plane support in vkms aligned with cursor and primary > plane with module option 'enable_overlay' to enable/disable overlay > plane while testing. > > This currently passes plane-position-cove