Re: [PATCH v3] drm/virtio: conditionally allocate virtio_gpu_fence

2023-07-07 Thread Dmitry Osipenko
On 7/7/23 20:59, Gurchetan Singh wrote: /// >>> Previously, when VIRTGPU_EXECBUF_RING_IDX flag wasn't specified, the >>> fence event was created for a default ring_idx=0. Now you changed this >>> behaviour and event will never be created without >>> VIRTGPU_EXECBUF_RING_IDX flag being set. > > rin

Re: [PATCH v3] drm/virtio: conditionally allocate virtio_gpu_fence

2023-07-07 Thread Gurchetan Singh
On Fri, Jul 7, 2023 at 10:35 AM Dmitry Osipenko wrote: > > On 7/7/23 20:04, Dmitry Osipenko wrote: > > On 7/7/23 18:43, Gurchetan Singh wrote: > >> @@ -161,21 +157,27 @@ static int virtio_gpu_init_submit(struct > >> virtio_gpu_submit *submit, > >>struct drm_file *f

Re: [PATCH v3] drm/virtio: conditionally allocate virtio_gpu_fence

2023-07-07 Thread Dmitry Osipenko
On 7/7/23 20:04, Dmitry Osipenko wrote: > On 7/7/23 18:43, Gurchetan Singh wrote: >> @@ -161,21 +157,27 @@ static int virtio_gpu_init_submit(struct >> virtio_gpu_submit *submit, >>struct drm_file *file, >>u64 fence_ctx, u32 ring_idx)

Re: [PATCH v3] drm/virtio: conditionally allocate virtio_gpu_fence

2023-07-07 Thread Dmitry Osipenko
On 7/7/23 18:43, Gurchetan Singh wrote: > @@ -161,21 +157,27 @@ static int virtio_gpu_init_submit(struct > virtio_gpu_submit *submit, > struct drm_file *file, > u64 fence_ctx, u32 ring_idx) > { > + int err; > + struct virtio_

[PATCH v3] drm/virtio: conditionally allocate virtio_gpu_fence

2023-07-07 Thread Gurchetan Singh
We don't want to create a fence for every command submission. It's only necessary when userspace provides a waitable token for submission. This could be: 1) bo_handles, to be used with VIRTGPU_WAIT 2) out_fence_fd, to be used with dma_fence apis 3) a ring_idx provided with VIRTGPU_CONTEXT_PARAM_P