Re: [PATCH v3] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-06 Thread Emil Velikov
On 2023/03/06, Dmitry Osipenko wrote: > On 3/6/23 19:39, Dmitry Osipenko wrote: > > VirtIO-GPU got a new config option for disabling KMS. There were two > > problems left unnoticed during review when the new option was added: > > > > 1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code w

Re: [PATCH v3] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-06 Thread Dmitry Osipenko
On 3/6/23 19:39, Dmitry Osipenko wrote: > VirtIO-GPU got a new config option for disabling KMS. There were two > problems left unnoticed during review when the new option was added: > > 1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code was > inverted, hence KMS was disabled when it sh

[PATCH v3] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-06 Thread Dmitry Osipenko
VirtIO-GPU got a new config option for disabling KMS. There were two problems left unnoticed during review when the new option was added: 1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code was inverted, hence KMS was disabled when it should be enabled and vice versa. 2. The disabled K