Re: [PATCH v3] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
On 13/02/2020 13:52, Jyri Sarha wrote: > On 13/02/2020 12:49, Tomi Valkeinen wrote: >> On 13/02/2020 12:44, Jyri Sarha wrote: >> >>> +    /* >>> + * If a plane on a CRTC changes add all active planes on that >>> + * CRTC to the atomic state. This is needed for updating the >>> + * plane

Re: [PATCH v3] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
On 13/02/2020 12:49, Tomi Valkeinen wrote: > On 13/02/2020 12:44, Jyri Sarha wrote: > >> +    /* >> + * If a plane on a CRTC changes add all active planes on that >> + * CRTC to the atomic state. This is needed for updating the >> + * plane positions in tidss_crtc_position_planes() whi

Re: [PATCH v3] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Tomi Valkeinen
On 13/02/2020 12:44, Jyri Sarha wrote: + /* +* If a plane on a CRTC changes add all active planes on that +* CRTC to the atomic state. This is needed for updating the +* plane positions in tidss_crtc_position_planes() which is +* called from crtc_atomic_enab

[PATCH v3] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
The old implementation of placing planes on the CRTC while configuring the planes was naive and relied on the order in which the planes were configured, enabled, and disabled. The situation where a plane's zpos was changed on the fly was completely broken. The usual symptoms of this problem was scr