Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-29 Thread Mary Guillemard
On Wed, Aug 28, 2024 at 11:09:09AM +0100, Mihail Atanassov wrote: > Do you have a link you can share with the userspace side of things? Assuming > userland has been reviewed and is ready for merging, and the small nitpick > above fixed, > > Reviewed-by: Mihail Atanassov > > -- > Mihail Atanasso

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-28 Thread Mihail Atanassov
On 28/08/2024 12:30, Boris Brezillon wrote: On Mon, 19 Aug 2024 13:25:08 +0200 Mary Guillemard wrote: +/** + * struct drm_panthor_timestamp_info - Timestamp information + * + * Structure grouping all queryable information relating to the GPU timestamp. + */ +struct drm_panthor_timestamp_inf

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-28 Thread Boris Brezillon
On Mon, 19 Aug 2024 13:25:08 +0200 Mary Guillemard wrote: > +/** > + * struct drm_panthor_timestamp_info - Timestamp information > + * > + * Structure grouping all queryable information relating to the GPU > timestamp. > + */ > +struct drm_panthor_timestamp_info { > + /** @timestamp_frequenc

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-28 Thread Mihail Atanassov
Hi Mary, On 28/08/2024 09:24, Mary Guillemard wrote: Hi Mihail, On Mon, Aug 19, 2024 at 03:25:48PM +0100, Mihail Atanassov wrote: diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index 926b1deb1116..944f5618aa05 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/incl

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-28 Thread Mary Guillemard
Hi Mihail, On Mon, Aug 19, 2024 at 03:25:48PM +0100, Mihail Atanassov wrote: > > diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h > > index 926b1deb1116..944f5618aa05 100644 > > --- a/include/uapi/drm/panthor_drm.h > > +++ b/include/uapi/drm/panthor_drm.h > > @@ -260,6

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-20 Thread Heiko Stübner
Am Montag, 19. August 2024, 13:25:08 CEST schrieb Mary Guillemard: > Expose timestamp information supported by the GPU with a new device > query. > > Mali uses an external timer as GPU system time. On ARM, this is wired to > the generic arch timer so we wire cntfrq_el0 as device frequency. > > Th

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-19 Thread Mihail Atanassov
Hi Mary, On 19/08/2024 12:25, Mary Guillemard wrote: Expose timestamp information supported by the GPU with a new device query. Mali uses an external timer as GPU system time. On ARM, this is wired to the generic arch timer so we wire cntfrq_el0 as device frequency. This new uAPI will be used

[PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-19 Thread Mary Guillemard
Expose timestamp information supported by the GPU with a new device query. Mali uses an external timer as GPU system time. On ARM, this is wired to the generic arch timer so we wire cntfrq_el0 as device frequency. This new uAPI will be used in Mesa to implement timestamp queries and VK_KHR_calibr