Re: [PATCH v3] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes

2024-06-28 Thread Lyude Paul
Ma Ke - I assume you already know but you can just ignore this message from Markus as it is just spam. Sorry about the trouble! Markus, you've already been asked by Greg so I will ask a bit more sternly in case there is actually a person on the other end: you've already been asked to stop by Greg

Re: [PATCH v3] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes

2024-06-27 Thread Markus Elfring
> In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a possible NULL pointer > dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. A) Can a wording approach (like the following) be a better change description?

[PATCH v3] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes

2024-06-27 Thread Ma Ke
In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: sta...@vger.kernel.org Fixes: 6ee738610f41 ("drm/nouveau: Add DRM driver for NVID