Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

2022-01-07 Thread Miles Chen
Hi Matthias, >> I'm still not happy with the commit subject, I think it is misleading. Clang >> only helped to find the bug, but the we are fixing something else, that's >> not >> just a clang warning. But I don't want to nit-pick too much so: >> >> Reviewed-by: Matthias Brugger > thanks. I

Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

2022-01-03 Thread miles.chen
> I'm still not happy with the commit subject, I think it is misleading. Clang > only helped to find the bug, but the we are fixing something else, that's not > just a clang warning. But I don't want to nit-pick too much so: > > Reviewed-by: Matthias Brugger thanks. I think you are right. I wi

[PATCH v3] drm/mediatek: Fix unused-but-set variable warning

2021-12-30 Thread Miles Chen
clang reports a unused-but-set variable warning: drivers/gpu/drm/mediatek/mtk_cec.c:85:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] In current implementation, mtk_cec_mask() writes val into target register and ignores the mask. After talking to our hdmi experts, mtk_cec

Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

2021-12-30 Thread Matthias Brugger
On 30/12/2021 10:36, Miles Chen wrote: clang reports a unused-but-set variable warning: drivers/gpu/drm/mediatek/mtk_cec.c:85:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] In current implementation, mtk_cec_mask() writes val into target register and ignores the mask