Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-04-17 Thread Inki Dae
2017년 04월 16일 20:50에 Tobias Jakobi 이(가) 쓴 글: > Hello Inki, > > Inki Dae wrote: > >> Tobias, why did you post the patch set 1/2 and 2/2 before? >> If these patches can be applied independently - you found out later - then >> you need to clarify why you posted them separately. > > > after I po

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-04-16 Thread Tobias Jakobi
Hello Inki, Inki Dae wrote: > Tobias, why did you post the patch set 1/2 and 2/2 before? > If these patches can be applied independently - you found out later - then > you need to clarify why you posted them separately. after I posted v1 of the patchset, Andrzej responded with a Reviewed-By fo

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-04-11 Thread Inki Dae
;>> You have added the wrong patch (v2 instead of v3). >> >> Tobias, >> >> you had posted this patch with other one like below, >> [PATCH v2 1/2] drm/exynos: mixer: simplify mixer_cfg_rgb_fmt() >> [PATCH v2 2/2] drm/exynos: mixer: document YCbCr magic numbers

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-04-11 Thread Tobias Jakobi
d this patch with other one like below, > [PATCH v2 1/2] drm/exynos: mixer: simplify mixer_cfg_rgb_fmt() > [PATCH v2 2/2] drm/exynos: mixer: document YCbCr magic numbers > > And than you have posted it without any comment again, v3, > [PATCH v3] drm/exynos: mixer: document YCbCr mag

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-04-10 Thread Inki Dae
g_rgb_fmt() [PATCH v2 2/2] drm/exynos: mixer: document YCbCr magic numbers And than you have posted it without any comment again, v3, [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers Please use --cover-letter option to make patch series and keep the patch set to be consistent with prev

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-04-10 Thread Tobias Jakobi
Inki Dae wrote: > 2017-03-29 20:56 GMT+09:00 Tobias Jakobi : >> Hello Daniel, >> >> same question here. Patch doesn't introduce any functional changes (just >> adds code documentation), so can you merge it through drm-misc? >> > > Sorry for late. Confirmed just now. I will check it on next Monday.

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-04-08 Thread Inki Dae
2017-03-29 20:56 GMT+09:00 Tobias Jakobi : > Hello Daniel, > > same question here. Patch doesn't introduce any functional changes (just > adds code documentation), so can you merge it through drm-misc? > Sorry for late. Confirmed just now. I will check it on next Monday. Thanks, Inki Dae > With

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-03-29 Thread Tobias Jakobi
Hello Daniel, same question here. Patch doesn't introduce any functional changes (just adds code documentation), so can you merge it through drm-misc? With best wishes, Tobias Tobias Jakobi wrote: > The output stage of the mixer uses YCbCr for the internal > computations, which is the reason th

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-03-22 Thread Tobias Jakobi
Gentle ping. - Tobias Tobias Jakobi wrote: > The output stage of the mixer uses YCbCr for the internal > computations, which is the reason that some registers take > YCbCr related data as input. In particular this applies > to MXR_BG_COLOR{0,1,2} and MXR_CM_COEFF_{Y,CB,CR}. > > Document the form

[PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-03-10 Thread Tobias Jakobi
The output stage of the mixer uses YCbCr for the internal computations, which is the reason that some registers take YCbCr related data as input. In particular this applies to MXR_BG_COLOR{0,1,2} and MXR_CM_COEFF_{Y,CB,CR}. Document the formatting of the data which we write to these registers. Wh