Re: [PATCH v3] drm/dp_mst: Rewrite and fix bandwidth limit checks

2020-03-10 Thread Mikita Lipski
On 3/9/20 5:01 PM, Lyude Paul wrote: Sigh, this is mostly my fault for not giving commit cd82d82cbc04 ("drm/dp_mst: Add branch bandwidth validation to MST atomic check") enough scrutiny during review. The way we're checking bandwidth limitations here is mostly wrong: For starters, drm_dp_mst_a

Re: [PATCH v3] drm/dp_mst: Rewrite and fix bandwidth limit checks

2020-03-09 Thread Alex Deucher
On Mon, Mar 9, 2020 at 5:01 PM Lyude Paul wrote: > > Sigh, this is mostly my fault for not giving commit cd82d82cbc04 > ("drm/dp_mst: Add branch bandwidth validation to MST atomic check") > enough scrutiny during review. The way we're checking bandwidth > limitations here is mostly wrong: > > For

[PATCH v3] drm/dp_mst: Rewrite and fix bandwidth limit checks

2020-03-09 Thread Lyude Paul
Sigh, this is mostly my fault for not giving commit cd82d82cbc04 ("drm/dp_mst: Add branch bandwidth validation to MST atomic check") enough scrutiny during review. The way we're checking bandwidth limitations here is mostly wrong: For starters, drm_dp_mst_atomic_check_bw_limit() determines the pbn