Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-02-03 Thread Daniel Vetter
On Fri, Jan 31, 2020 at 08:08:34AM +, Benjamin GAIGNARD wrote: > > On 1/31/20 12:22 AM, Dave Airlie wrote: > hi-actually yes, we should probably be using this instead of just > dropping > this. Also, I didn't write this code originally I just refactored a bunch > of >

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-02-03 Thread Benjamin GAIGNARD
On 1/31/20 12:22 AM, Dave Airlie wrote: hi-actually yes, we should probably be using this instead of just dropping this. Also, I didn't write this code originally I just refactored a bunch of it - Dave Airlied is the original author, but the original version of this code w

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-30 Thread Dave Airlie
> > > > > > > hi-actually yes, we should probably be using this instead of just dropping > > > this. Also, I didn't write this code originally I just refactored a bunch > > > of > > > it - Dave Airlied is the original author, but the original version of this > > > code was written ages ago. tbh, I

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-30 Thread Lyude Paul
On Mon, 2020-01-27 at 14:08 +0100, Benjamin Gaignard wrote: > Le ven. 24 janv. 2020 à 23:08, Lyude Paul a écrit : > > On Tue, 2020-01-07 at 14:11 +0100, Benjamin Gaignard wrote: > > > Le ven. 20 déc. 2019 à 15:03, Benjamin Gaignard > > > a écrit : > > > > Le lun. 16 déc. 2019 à 09:28, Benjamin Ga

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-27 Thread Benjamin Gaignard
Le ven. 24 janv. 2020 à 23:08, Lyude Paul a écrit : > > On Tue, 2020-01-07 at 14:11 +0100, Benjamin Gaignard wrote: > > Le ven. 20 déc. 2019 à 15:03, Benjamin Gaignard > > a écrit : > > > Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard > > > a écrit : > > > > Le mer. 4 déc. 2019 à 17:47, Jani Ni

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-24 Thread Lyude Paul
On Tue, 2020-01-07 at 14:11 +0100, Benjamin Gaignard wrote: > Le ven. 20 déc. 2019 à 15:03, Benjamin Gaignard > a écrit : > > Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard > > a écrit : > > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > > > écrit : > > > > On Thu, 28 Nov 2019, Benjamin Gaignar

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-18 Thread Benjamin Gaignard
Le sam. 18 janv. 2020 à 01:55, Lyude Paul a écrit : > > Hey, does this still need review? yes please. There is a question about what we should do of crc4 variable below. Thanks, Benjamin > > On Tue, 2020-01-07 at 14:11 +0100, Benjamin Gaignard wrote: > > Le ven. 20 déc. 2019 à 15:03, Benjamin Ga

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-17 Thread Lyude Paul
Hey, does this still need review? On Tue, 2020-01-07 at 14:11 +0100, Benjamin Gaignard wrote: > Le ven. 20 déc. 2019 à 15:03, Benjamin Gaignard > a écrit : > > Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard > > a écrit : > > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > > > écrit : > > > > On

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-07 Thread Benjamin Gaignard
Le ven. 20 déc. 2019 à 15:03, Benjamin Gaignard a écrit : > > Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard > a écrit : > > > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > > écrit : > > > > > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > > > > Fix the warnings that show up with W=1. > >

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-20 Thread Benjamin Gaignard
Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard a écrit : > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > écrit : > > > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > > > Fix the warnings that show up with W=1. > > > They are all about unused but set variables. > > > If functions returns ar

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-16 Thread Benjamin Gaignard
Le mer. 4 déc. 2019 à 17:47, Jani Nikula a écrit : > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > > Fix the warnings that show up with W=1. > > They are all about unused but set variables. > > If functions returns are not used anymore make them void. > > > > Signed-off-by: Benjamin Gaignard

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-04 Thread Jani Nikula
On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > Fix the warnings that show up with W=1. > They are all about unused but set variables. > If functions returns are not used anymore make them void. > > Signed-off-by: Benjamin Gaignard > --- > CC: Jani Nikula > > changes in version 3: > - remove the

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-03 Thread Benjamin Gaignard
Le sam. 30 nov. 2019 à 14:24, Benjamin Gaignard a écrit : > > Fix the warnings that show up with W=1. > They are all about unused but set variables. > If functions returns are not used anymore make them void. > > Signed-off-by: Benjamin Gaignard > --- > CC: Jani Nikula > > changes in version 3:

[PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-11-30 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. If functions returns are not used anymore make them void. Signed-off-by: Benjamin Gaignard --- CC: Jani Nikula changes in version 3: - remove the hunk that may conflict with c485e2c97dae ("drm/dp_mst: Refact