Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-25 Thread Laurent Pinchart
On Fri, Aug 25, 2023 at 06:48:45AM +0300, Andy Shevchenko wrote: > On Thu, Aug 24, 2023 at 9:26 PM Laurent Pinchart wrote: > > On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: > > ... > > > I wonder, as the device can only be instantiated from OF, should we add > > > > depends on

Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Andy Shevchenko
On Thu, Aug 24, 2023 at 9:26 PM Laurent Pinchart wrote: > On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: ... > I wonder, as the device can only be instantiated from OF, should we add > > depends on OF Generally speaking this is a bad idea. It prevents a component from being i

Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Laurent Pinchart
On Thu, Aug 24, 2023 at 01:51:59PM -0700, Doug Anderson wrote: > On Thu, Aug 24, 2023 at 11:26 AM Laurent Pinchart wrote: > > On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: > > > The driver has an ID table, but it uses the wrong API for retrieving match > > > data and that will lead to a

Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Doug Anderson
Hi, On Thu, Aug 24, 2023 at 11:26 AM Laurent Pinchart wrote: > > Hi Biju, > > Thank you for the patch. > > On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: > > The driver has an ID table, but it uses the wrong API for retrieving match > > data and that will lead to a crash, if it is inst

RE: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table > > Hi Biju, > > Thank you for the patch. > > On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: > > The driver has an ID table, but it uses t

Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: > The driver has an ID table, but it uses the wrong API for retrieving match > data and that will lead to a crash, if it is instantiated by user space or > using ID. From this, there is no user for the ID

Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Doug Anderson
Hi, On Thu, Aug 24, 2023 at 11:15 AM Biju Das wrote: > > The driver has an ID table, but it uses the wrong API for retrieving match > data and that will lead to a crash, if it is instantiated by user space or > using ID. From this, there is no user for the ID table and let's drop it > from the dr

[PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Biju Das
The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das --- v2->v