Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-19 Thread John Stultz
On Wed, Jan 19, 2022 at 1:58 AM Guangming.Cao wrote: > On Fri, 2022-01-14 at 17:17 -0800, John Stultz wrote: > > If the max value is per-heap, why not enforce that value in the > > per-heap allocation function? > > > > Moving the check to the heap alloc to me seems simpler to me than > > adding co

Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-19 Thread Guangming . Cao
On Fri, 2022-01-14 at 17:17 -0800, John Stultz wrote: > On Fri, Jan 14, 2022 at 4:04 AM Guangming.Cao > wrote: > > > > On Fri, 2022-01-14 at 08:16 +0100, Christian König wrote: > > > Am 14.01.22 um 00:26 schrieb John Stultz: > > > > On Thu, Jan 13, 2022 at 5:05 AM Christian König > > > > wrote:

Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-14 Thread John Stultz
On Fri, Jan 14, 2022 at 4:04 AM Guangming.Cao wrote: > > On Fri, 2022-01-14 at 08:16 +0100, Christian König wrote: > > Am 14.01.22 um 00:26 schrieb John Stultz: > > > On Thu, Jan 13, 2022 at 5:05 AM Christian König > > > wrote: > > > > Am 13.01.22 um 14:00 schrieb Ruhl, Michael J: > > > > > > ---

Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-14 Thread Guangming . Cao
On Fri, 2022-01-14 at 08:16 +0100, Christian König wrote: > Am 14.01.22 um 00:26 schrieb John Stultz: > > On Thu, Jan 13, 2022 at 5:05 AM Christian König > > wrote: > > > Am 13.01.22 um 14:00 schrieb Ruhl, Michael J: > > > > > -Original Message- > > > > > From: dri-devel On > > > > > Beha

Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-13 Thread Christian König
Am 14.01.22 um 00:26 schrieb John Stultz: On Thu, Jan 13, 2022 at 5:05 AM Christian König wrote: Am 13.01.22 um 14:00 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Ruhl, Michael J -Original Message- From: dri-devel On Behalf Of guangming@mediat

Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-13 Thread John Stultz
On Thu, Jan 13, 2022 at 5:05 AM Christian König wrote: > Am 13.01.22 um 14:00 schrieb Ruhl, Michael J: > >> -Original Message- > >> From: dri-devel On Behalf Of > >> Ruhl, Michael J > >>> -Original Message- > >>> From: dri-devel On Behalf Of > >>> guangming@mediatek.com > >>>

Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-13 Thread Christian König
; mingyuan...@mediatek.com; linux-arm-ker...@lists.infradead.org; linux- me...@vger.kernel.org Subject: RE: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation -Original Message- From: dri-devel On Behalf Of guangming@mediatek.com Sent: Thursday, January 13, 2022 7:34 AM To

RE: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-13 Thread Ruhl, Michael J
om; >mingyuan...@mediatek.com; linux-arm-ker...@lists.infradead.org; linux- >me...@vger.kernel.org >Subject: RE: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation > > >>-Original Message- >>From: dri-devel On Behalf Of >>guangming@me

RE: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-13 Thread Ruhl, Michael J
..@redhat.com; christian.koe...@amd.com; >jianjiao.z...@mediatek.com; linux-me...@vger.kernel.org >Subject: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation > >From: Guangming > >Add a size check for allocation since the allocation size is >always less than the t

[PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-13 Thread guangming.cao
From: Guangming Add a size check for allocation since the allocation size is always less than the total DRAM size. Without this check, once the invalid size allocation runs on a process that can't be killed by OOM flow(such as "gralloc" on Android devices), it will cause a kernel exception, and