[PATCH v2 hmm 4/9] mm/hmm: remove HMM_FAULT_SNAPSHOT

2020-03-30 Thread Jason Gunthorpe
From: Jason Gunthorpe Now that flags are handled on a fine-grained per-page basis this global flag is redundant and has a confusing overlap with the pfn_flags_mask and default_flags. Normalize the HMM_FAULT_SNAPSHOT behavior into one place. Callers needing the SNAPSHOT behavior should set a pfn_

Re: [PATCH v2 hmm 4/9] mm/hmm: remove HMM_FAULT_SNAPSHOT

2020-03-25 Thread Jason Gunthorpe
On Tue, Mar 24, 2020 at 08:33:39AM +0100, Christoph Hellwig wrote: > > > > +/* > > + * If the valid flag is masked off, and default_flags doesn't set valid, > > then > > + * hmm_pte_need_fault() always returns 0. > > + */ > > +static bool hmm_can_fault(struct hmm_range *range) > > +{ > > + ret

[PATCH v2 hmm 4/9] mm/hmm: remove HMM_FAULT_SNAPSHOT

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe Now that flags are handled on a fine-grained per-page basis this global flag is redundant and has a confusing overlap with the pfn_flags_mask and default_flags. Normalize the HMM_FAULT_SNAPSHOT behavior into one place. Callers needing the SNAPSHOT behavior should set a pfn_