Re: [PATCH v2 9/9] drm/panel: Add Ronbo RB070D30 panel

2019-02-11 Thread Maxime Ripard
hi, On Fri, Feb 08, 2019 at 03:24:12PM +0300, Konstantin Sudakov wrote: > Hello, Maxime! > > >+mode = drm_mode_duplicate(panel->drm, &default_mode); > >+if (!mode) { > >+DRM_DEV_ERROR(&ctx->dsi->dev, > >+ "Failed to add mode " DRM_MODE_FMT "\n", > >+ DRM_MODE_ARG(mode)); > >+return -EIN

Re: [PATCH v2 9/9] drm/panel: Add Ronbo RB070D30 panel

2019-02-08 Thread Sam Ravnborg
Hi Maxime, On Fri, Feb 08, 2019 at 10:53:22AM +0100, Maxime Ripard wrote: > From: Konstantin Sudakov > > The Ronbo RB070D30 panel is a MIPI-DSI panel based on a Fitipower EK79007 > controller and a 1024x600 panel. > > Signed-off-by: Konstantin Sudakov > Signed-off-by: Maxime Ripard Driver lo

[PATCH v2 9/9] drm/panel: Add Ronbo RB070D30 panel

2019-02-08 Thread Konstantin Sudakov
Hello, Maxime! >+mode = drm_mode_duplicate(panel->drm, &default_mode); >+if (!mode) { >+DRM_DEV_ERROR(&ctx->dsi->dev, >+ "Failed to add mode " DRM_MODE_FMT "\n", >+ DRM_MODE_ARG(mode)); >+return -EINVAL; >+} Just small fix: DRM_MODE_ARG(mode) -> DRM_MODE_ARG(&default_mode). The "mode" v

[PATCH v2 9/9] drm/panel: Add Ronbo RB070D30 panel

2019-02-08 Thread Maxime Ripard
From: Konstantin Sudakov The Ronbo RB070D30 panel is a MIPI-DSI panel based on a Fitipower EK79007 controller and a 1024x600 panel. Signed-off-by: Konstantin Sudakov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/Kconfig| 9 +- drivers/gpu/drm/panel/Makefile