Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-22 Thread Kishon Vijay Abraham I
Hi, On 21/11/18 7:17 PM, Maxime Ripard wrote: > Hi Kishon, > > On Wed, Nov 21, 2018 at 03:59:43PM +0530, Kishon Vijay Abraham I wrote: >> On 21/11/18 3:41 PM, Maxime Ripard wrote: >>> Hi Kishon, >>> >>> On Tue, Nov 20, 2018 at 11:02:34AM +0530, Kishon Vijay Abraham I wrote: >> +static int cdn

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-22 Thread Kishon Vijay Abraham I
Hi Maxime, On 21/11/18 3:41 PM, Maxime Ripard wrote: > Hi Kishon, > > On Tue, Nov 20, 2018 at 11:02:34AM +0530, Kishon Vijay Abraham I wrote: +static int cdns_dphy_config_from_opts(struct phy *phy, +struct phy_configure_opts_mipi_dphy *opts, +

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-21 Thread Maxime Ripard
Hi Kishon, On Wed, Nov 21, 2018 at 03:59:43PM +0530, Kishon Vijay Abraham I wrote: > On 21/11/18 3:41 PM, Maxime Ripard wrote: > > Hi Kishon, > > > > On Tue, Nov 20, 2018 at 11:02:34AM +0530, Kishon Vijay Abraham I wrote: > +static int cdns_dphy_config_from_opts(struct phy *phy, > +

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-21 Thread Maxime Ripard
Hi Sakari, On Mon, Nov 19, 2018 at 11:24:20PM +0200, Sakari Ailus wrote: > Hi Maxime, > > On Tue, Nov 06, 2018 at 03:54:20PM +0100, Maxime Ripard wrote: > > Cadence has designed a D-PHY that can be used by the, currently in tree, > > DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drive

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-21 Thread Maxime Ripard
Hi Kishon, On Tue, Nov 20, 2018 at 11:02:34AM +0530, Kishon Vijay Abraham I wrote: > > > +static int cdns_dphy_config_from_opts(struct phy *phy, > > > + struct phy_configure_opts_mipi_dphy *opts, > > > + struct cdns_dphy_cfg *cfg) > > > +

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-20 Thread Kishon Vijay Abraham I
Hi, On 12/11/18 3:21 PM, Kishon Vijay Abraham I wrote: Hi Maxime, On 06/11/18 8:24 PM, Maxime Ripard wrote: Cadence has designed a D-PHY that can be used by the, currently in tree, DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers. Only the DSI driver has an ad-hoc driver for

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-19 Thread Sakari Ailus
Hi Maxime, On Tue, Nov 06, 2018 at 03:54:20PM +0100, Maxime Ripard wrote: > Cadence has designed a D-PHY that can be used by the, currently in tree, > DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers. > > Only the DSI driver has an ad-hoc driver for that phy at the moment, while

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-16 Thread Maxime Ripard
Hi! On Mon, Nov 12, 2018 at 03:21:56PM +0530, Kishon Vijay Abraham I wrote: > > +static int cdns_dphy_validate(struct phy *phy, enum phy_mode mode, > > + union phy_configure_opts *opts) > > +{ > > + struct cdns_dphy_cfg cfg = { 0 }; > > + > > + if (mode != PHY_MODE_MIPI

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-12 Thread Kishon Vijay Abraham I
Hi Maxime, On 06/11/18 8:24 PM, Maxime Ripard wrote: > Cadence has designed a D-PHY that can be used by the, currently in tree, > DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers. > > Only the DSI driver has an ad-hoc driver for that phy at the moment, while > the v4l2 drivers ar

[PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-06 Thread Maxime Ripard
Cadence has designed a D-PHY that can be used by the, currently in tree, DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers. Only the DSI driver has an ad-hoc driver for that phy at the moment, while the v4l2 drivers are completely missing any phy support. In order to make that phy