Re: [PATCH v2 7/8] drm/amdgpu: Fix sdma code crash post device unplug

2020-06-23 Thread Christian König
Am 23.06.20 um 07:11 schrieb Andrey Grodzovsky: On 6/22/20 3:40 PM, Christian König wrote: Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky: entity->rq becomes null aftre device unplugged so just return early in that case. Mhm, do you have a backtrace for this? This should only be called by a

Re: [PATCH v2 7/8] drm/amdgpu: Fix sdma code crash post device unplug

2020-06-22 Thread Andrey Grodzovsky
On 6/22/20 3:40 PM, Christian König wrote: Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky: entity->rq becomes null aftre device unplugged so just return early in that case. Mhm, do you have a backtrace for this? This should only be called by an IOCTL and IOCTLs should already call drm_dev_e

Re: [PATCH v2 7/8] drm/amdgpu: Fix sdma code crash post device unplug

2020-06-22 Thread Christian König
Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky: entity->rq becomes null aftre device unplugged so just return early in that case. Mhm, do you have a backtrace for this? This should only be called by an IOCTL and IOCTLs should already call drm_dev_enter()/exit() on their own... Christian.

Re: [PATCH v2 7/8] drm/amdgpu: Fix sdma code crash post device unplug

2020-06-22 Thread Daniel Vetter
On Sun, Jun 21, 2020 at 02:03:07AM -0400, Andrey Grodzovsky wrote: > entity->rq becomes null aftre device unplugged so just return early > in that case. > > Signed-off-by: Andrey Grodzovsky That looks very deep in amdgpu internals ... how do you even get in here after the device is fully unplugg

[PATCH v2 7/8] drm/amdgpu: Fix sdma code crash post device unplug

2020-06-20 Thread Andrey Grodzovsky
entity->rq becomes null aftre device unplugged so just return early in that case. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.