Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag

2022-06-29 Thread Sumit Semwal
On Mon, 27 Jun 2022 at 14:38, Daniel Vetter wrote: > > On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > > This is already set by anon_inode_getfile(), since dma_buf_fops has > > non-NULL ->llseek, so we don't need to set it here too. > > > > Suggested-by: Al Viro > > Cc: Sumi

Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag

2022-06-27 Thread Jason A. Donenfeld
Hi Daniel, On Mon, Jun 27, 2022 at 11:08:32AM +0200, Daniel Vetter wrote: > On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > > This is already set by anon_inode_getfile(), since dma_buf_fops has > > non-NULL ->llseek, so we don't need to set it here too. > > > > Suggested-by:

Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag

2022-06-27 Thread Daniel Vetter
On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > This is already set by anon_inode_getfile(), since dma_buf_fops has > non-NULL ->llseek, so we don't need to set it here too. > > Suggested-by: Al Viro > Cc: Sumit Semwal > Cc: Christian König > Cc: dri-devel@lists.freedeskto

[PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag

2022-06-25 Thread Jason A. Donenfeld
This is already set by anon_inode_getfile(), since dma_buf_fops has non-NULL ->llseek, so we don't need to set it here too. Suggested-by: Al Viro Cc: Sumit Semwal Cc: Christian König Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jason A. Donenfeld --- drivers/dma-buf/dma-buf.c | 1 - 1 f