Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-09 Thread Christian König
Am 09.12.20 um 11:16 schrieb Daniel Vetter: [SNIP] At least I would be fine with that. For now amdgpu is the only exporter who implements the explicit pin/unpin semantics anyway. Yup, I think that makes sense (if it works). Maybe we could use something like: a) dma_buf pin exists, driver is dy

Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-09 Thread Daniel Vetter
On Wed, Dec 9, 2020 at 10:32 AM Thomas Zimmermann wrote: > > Hi > > Am 09.12.20 um 01:13 schrieb Daniel Vetter: > > On Fri, Dec 04, 2020 at 09:47:08AM +0100, Christian König wrote: > >> Am 04.12.20 um 09:32 schrieb Thomas Zimmermann: > >>> Hi > >>> > >>> Am 03.12.20 um 21:41 schrieb Daniel Vetter:

Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-09 Thread Thomas Zimmermann
Hi Am 09.12.20 um 01:13 schrieb Daniel Vetter: On Fri, Dec 04, 2020 at 09:47:08AM +0100, Christian König wrote: Am 04.12.20 um 09:32 schrieb Thomas Zimmermann: Hi Am 03.12.20 um 21:41 schrieb Daniel Vetter: On Thu, Dec 03, 2020 at 07:59:04PM +0100, Thomas Zimmermann wrote: Hi Am 03.12.20 u

Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-08 Thread Daniel Vetter
On Fri, Dec 04, 2020 at 09:47:08AM +0100, Christian König wrote: > Am 04.12.20 um 09:32 schrieb Thomas Zimmermann: > > Hi > > > > Am 03.12.20 um 21:41 schrieb Daniel Vetter: > > > On Thu, Dec 03, 2020 at 07:59:04PM +0100, Thomas Zimmermann wrote: > > > > Hi > > > > > > > > Am 03.12.20 um 16:26 sc

Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-04 Thread Christian König
Am 04.12.20 um 09:32 schrieb Thomas Zimmermann: Hi Am 03.12.20 um 21:41 schrieb Daniel Vetter: On Thu, Dec 03, 2020 at 07:59:04PM +0100, Thomas Zimmermann wrote: Hi Am 03.12.20 um 16:26 schrieb Daniel Vetter: On Thu, Dec 03, 2020 at 03:02:59PM +0100, Thomas Zimmermann wrote: Dma-buf's vmap

Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-04 Thread Thomas Zimmermann
Hi Am 03.12.20 um 21:41 schrieb Daniel Vetter: On Thu, Dec 03, 2020 at 07:59:04PM +0100, Thomas Zimmermann wrote: Hi Am 03.12.20 um 16:26 schrieb Daniel Vetter: On Thu, Dec 03, 2020 at 03:02:59PM +0100, Thomas Zimmermann wrote: Dma-buf's vmap and vunmap callbacks are undocumented and various

Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-03 Thread Daniel Vetter
On Thu, Dec 03, 2020 at 07:59:04PM +0100, Thomas Zimmermann wrote: > Hi > > Am 03.12.20 um 16:26 schrieb Daniel Vetter: > > On Thu, Dec 03, 2020 at 03:02:59PM +0100, Thomas Zimmermann wrote: > > > Dma-buf's vmap and vunmap callbacks are undocumented and various > > > exporters currently have sligh

Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-03 Thread Thomas Zimmermann
Hi Am 03.12.20 um 16:26 schrieb Daniel Vetter: On Thu, Dec 03, 2020 at 03:02:59PM +0100, Thomas Zimmermann wrote: Dma-buf's vmap and vunmap callbacks are undocumented and various exporters currently have slightly different semantics for them. Add documentation on how to implement and use these

Re: [PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-03 Thread Daniel Vetter
On Thu, Dec 03, 2020 at 03:02:59PM +0100, Thomas Zimmermann wrote: > Dma-buf's vmap and vunmap callbacks are undocumented and various > exporters currently have slightly different semantics for them. Add > documentation on how to implement and use these interfaces correctly. > > v2: > * docu

[PATCH v2 7/7] dma-buf: Write down some rules for vmap usage

2020-12-03 Thread Thomas Zimmermann
Dma-buf's vmap and vunmap callbacks are undocumented and various exporters currently have slightly different semantics for them. Add documentation on how to implement and use these interfaces correctly. v2: * document vmap semantics in struct dma_buf_ops * add TODO item for reviewi