Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-05 Thread Alexey Makhalov
On 12/5/23 3:03 PM, Dave Hansen wrote: On 12/5/23 13:41, Alexey Makhalov wrote: I don't really like it much.  This does a generic thing (make a TDX hypercall) with a specific name ("vmware_").  If you want to make an argument that a certain chunk of the __tdx_hypercall() space is just for VMW

Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-05 Thread Dave Hansen
On 12/5/23 13:41, Alexey Makhalov wrote: >> I don't really like it much.  This does a generic thing (make a TDX >> hypercall) with a specific name ("vmware_").  If you want to make an >> argument that a certain chunk of the __tdx_hypercall() space is just for >> VMWare and you also add a VMWare-spe

Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-05 Thread Tim Merrifield
Hi Dave and Alexey, Regarding VMware-specific checks, it may be beneficial to add some additional checks such as ensuring that the hypervisor vendor is VMware, r12==VMWARE_HYPERVISOR_MAGIC, r10==VMWARE_TDX_VENDOR_LEAF, r11==VMWARE_TDX_HCALL_FUNC and r13 (command) is restricted to those few command

Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-05 Thread Alexey Makhalov
On 12/5/23 1:24 PM, Dave Hansen wrote: On 12/4/23 02:31, Borislav Petkov wrote: On Fri, Dec 01, 2023 at 03:24:52PM -0800, Alexey Makhalov wrote: +#ifdef CONFIG_INTEL_TDX_GUEST +/* __tdx_hypercall() is not exported. So, export the wrapper */ +void vmware_tdx_hypercall_args(struct tdx_module_a

Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-05 Thread Dave Hansen
On 12/4/23 02:31, Borislav Petkov wrote: > On Fri, Dec 01, 2023 at 03:24:52PM -0800, Alexey Makhalov wrote: >> +#ifdef CONFIG_INTEL_TDX_GUEST >> +/* __tdx_hypercall() is not exported. So, export the wrapper */ >> +void vmware_tdx_hypercall_args(struct tdx_module_args *args) >> +{ >> +__tdx_hype

Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-05 Thread kernel test robot
72821 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231201232452.220355-7-amakhalov%40vmware.com patch subject: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support config: i386-buildonly-randconfig-005-20231202 (https://download.01.o

Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-05 Thread kernel test robot
72821 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231201232452.220355-7-amakhalov%40vmware.com patch subject: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support config: x86_64-buildonly-randconfig-003-20231203 (https://download.01.o

Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-04 Thread Borislav Petkov
On Fri, Dec 01, 2023 at 03:24:52PM -0800, Alexey Makhalov wrote: > +#ifdef CONFIG_INTEL_TDX_GUEST > +/* __tdx_hypercall() is not exported. So, export the wrapper */ > +void vmware_tdx_hypercall_args(struct tdx_module_args *args) > +{ > + __tdx_hypercall(args); > +} > +EXPORT_SYMBOL_GPL(vmware_t

[PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-01 Thread Alexey Makhalov
VMware hypercalls use I/O port, VMCALL or VMMCALL instructions. Add __tdx_hypercall path to support TDX guests. No change in high bandwidth hypercalls, as only low bandwidth ones are supported for TDX guests. Co-developed-by: Tim Merrifield Signed-off-by: Tim Merrifield Signed-off-by: Alexey Ma