[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-12 Thread Daniel Vetter
On Thu, May 12, 2016 at 12:18 PM, Noralf Trønnes wrote: > Den 12.05.2016 10:11, skrev Daniel Vetter: >> >> On Wed, May 11, 2016 at 07:09:10PM +0200, Daniel Vetter wrote: >>> >>> On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: +/** + * drm_simple_display_pipe_init -

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-12 Thread Noralf Trønnes
Den 12.05.2016 10:11, skrev Daniel Vetter: > On Wed, May 11, 2016 at 07:09:10PM +0200, Daniel Vetter wrote: >> On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: >>> +/** >>> + * drm_simple_display_pipe_init - Initialize a simple display pipeline >>> + * @dev: DRM device >>> + * @pipe

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-12 Thread Daniel Vetter
On Wed, May 11, 2016 at 07:09:10PM +0200, Daniel Vetter wrote: > On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: > > +/** > > + * drm_simple_display_pipe_init - Initialize a simple display pipeline > > + * @dev: DRM device > > + * @pipe: simple display pipe object to initialize > >

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Den 11.05.2016 21:10, skrev Paul Bolle: > On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote: >> On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: >>> --- a/drivers/gpu/drm/Kconfig >>> +++ b/drivers/gpu/drm/Kconfig >>> +config DRM_SIMPLE_KMS_HELPER >>> + tristate >>> + depend

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Den 11.05.2016 19:09, skrev Daniel Vetter: > On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: >> Provides helper functions for drivers that have a simple display >> pipeline. Plane, crtc and encoder are collapsed into one entity. >> >> Signed-off-by: Noralf Trønnes > Looks really

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Paul Bolle
On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote: > On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > +config DRM_SIMPLE_KMS_HELPER > > + tristate > > + depends on DRM > > + select DRM_KMS_HELPER > >

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Daniel Vetter
On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: > Provides helper functions for drivers that have a simple display > pipeline. Plane, crtc and encoder are collapsed into one entity. > > Signed-off-by: Noralf Trønnes Looks really nice, just a few suggestions for the kerneldoc. W

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes --- Changes since v1: - Add DOC header and add to gpu.tmpl - Fix docs: @funcs is optional, "negative error code", "This hook is optio