Re: [PATCH v2 5/7] drm/i2c: tda9950: add CEC driver

2017-12-12 Thread Russell King - ARM Linux
On Wed, Dec 06, 2017 at 03:11:43PM +0100, Hans Verkuil wrote: > Hi Russell, > > Some small comments below: > > On 12/06/17 13:35, Russell King wrote: > > + /* > > +* This should never happen: the data sheet says that there will > > +* always be a valid message if the interrupt line is a

[PATCH v2 5/7] drm/i2c: tda9950: add CEC driver

2017-12-06 Thread Russell King
Add a CEC driver for the TDA9950, which is a stand-alone I2C CEC device, but is also integrated into HDMI transceivers such as the TDA9989 and TDA19989. The TDA9950 contains a command processor which handles retransmissions and the low level bus protocol. The driver just has to read and write the

Re: [PATCH v2 5/7] drm/i2c: tda9950: add CEC driver

2017-12-06 Thread Hans Verkuil
Hi Russell, Some small comments below: On 12/06/17 13:35, Russell King wrote: > Add a CEC driver for the TDA9950, which is a stand-alone I2C CEC device, > but is also integrated into HDMI transceivers such as the TDA9989 and > TDA19989. > > The TDA9950 contains a command processor which handles